Rewrite in Java, drop Scala dependencies #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almson
force-pushed
the
master
branch
2 times, most recently
from
7273222 to
506daa4
Compare
added 6 commits
January 13, 2022 12:06
A non-required property can be non-nullable. It can either be omitted, or if specified must be non-null.
almson
force-pushed
the
master
branch
2 times, most recently
from
2b95da9 to
21163e3
Compare
|
Please consider this PR seriously. The Scala collection dependencies really hurt. |
added 4 commits
June 7, 2023 14:30
|
Why is nobody merging this? |
|
@mbknor who is the active maintainer? |
|
@muliyul @kyale Thank you for the support. Expecting a project to switch languages and accept a rewrite pull request is a tall order. Feel free to just switch to my fork. It's on Maven, I've been updating it with features/fixes (see the master 1.1.2 branch), and will take PRs. Beside, this project brags in the README "Benefits: Simple implementation - Just one file" The file is 1500 lines. So idk what you can expect from the maintainer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #160 Tests pass. This has the same behavior as 1.0.39, with fix to #152.
Most of the changes are straight conversions from Scala to Java. Use of Option and endless
mapandforeachhas been eliminated in favor of simpleif(... != null). A few things were refactored such as moved into separate files, but not much. The Java code actually ended up being more concise and definitely a lot clearer than Scala.EDIT: I realized I should have made a separate branch with original groupId, etc. If there's interest, I'll recreate this PR.