Use M_PI instead of M_PIl #96
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M_PIl is the double precision constant for pi (3.14...).
This is not defined in all toolchains, resulting in the
following build error:
```
test/testcpp.cc:46:35: error: use of undeclared identifier 'M_PIl'; did you mean 'P_PID'?
46 | long double phinc = 2*k0* M_PIl / nfft;
| ^~~~~
| P_PID
```
The double precision constants may be a GNU extension. See:
https://www.gnu.org/software/libc/manual/html_node/Mathematical-Constants.html_node
Switching the test to use the single precision M_PI avoids this
error. The test still passes as the added precision of the
double is not required.
This fixes mborgerding#87.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
M_PIl is the double precision constant for pi (3.14...). This is not defined in all toolchains, resulting in the following build error:
The double precision constants may be a GNU extension. See: https://www.gnu.org/software/libc/manual/html_node/Mathematical-Constants.html_node
Switching the test to use the single precision M_PI avoids this error. The test still passes as the added precision of the double is not required.
This fixes #87.