Skip to content

Commit

Permalink
Version 3.20.2
Browse files Browse the repository at this point in the history
  • Loading branch information
mborsetti committed Mar 16, 2024
1 parent a948fb7 commit 550b3d5
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 10 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,14 @@ can check out the `wish list <https://github.com/mborsetti/webchanges/blob/main/
Security, in case of vulnerabilities. [triggers a minor patch]
Internals, for changes that don't affect users. [triggers a minor patch]
Version 3.20.2
===================
2024-03-16

Fixed
-----
* Parsing the ``to`` address for the ``sendmail`` ``email`` reporter.

Version 3.20.1
===================
2024-03-16
Expand Down
2 changes: 1 addition & 1 deletion RELEASE.rst
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Fixed
-----
* Regression introduced in supporting sending to multiple "to" addresses.
* Parsing the ``to`` address for the ``sendmail`` ``email`` reporter.
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

[tox]
requires =
tox>=4.13.0
tox>=4.14.1
virtualenv>=20.25.1
env_list =
pre-commit,
Expand Down
2 changes: 1 addition & 1 deletion webchanges/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
# * MINOR version when you add functionality in a backwards compatible manner, and
# * MICRO or PATCH version when you make backwards compatible bug fixes. We no longer use '0'
# If unsure on increments, use pkg_resources.parse_version to parse
__version__ = '3.20.1'
__version__ = '3.20.2'
__description__ = (
'Check web (or command output) for changes since last run and notify.\n'
'\n'
Expand Down
11 changes: 4 additions & 7 deletions webchanges/mailer.py
Original file line number Diff line number Diff line change
Expand Up @@ -119,14 +119,11 @@ def send(self, msg: Union[EmailMessage]) -> None:
:param msg: The message to be sent.
"""
if msg['From']:
command = [self.sendmail_path, '-oi', msg['To'] + [addr.strip() for addr in msg['To'].split(',')]]
else:
command = [
self.sendmail_path,
'-oi',
'-f',
msg['From'] + [addr.strip() for addr in msg['To'].split(',')],
command = [self.sendmail_path, '-oi', '-f', msg['From']] + [
addr.strip() for addr in msg['To'].split(',' '')
]
else:
command = [self.sendmail_path, '-oi'] + [addr.strip() for addr in msg['To'].split(',')]
p = subprocess.run( # noqa: S603 subprocess call - check for execution of untrusted input.
command,
input=msg.as_string(),
Expand Down

0 comments on commit 550b3d5

Please sign in to comment.