Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool View schema definition #128

Closed
Bankso opened this issue Jul 24, 2024 · 0 comments · Fixed by #129
Closed

Tool View schema definition #128

Bankso opened this issue Jul 24, 2024 · 0 comments · Fixed by #129
Assignees
Labels
bug Something isn't working patch PR label for a patch update

Comments

@Bankso
Copy link
Contributor

Bankso commented Jul 24, 2024

Related to #120

I went to generate a Tool View manifest and noticed the new attributes were not included in the sheet.

@aditigopalan mentioned that the dependsOn field had not been updated to reflect the updated Tool View model, but there are a couple additional things to address before the model is integrated:

  • new attributes must be added to the dependsOn column of the Tool View attribute row
  • Valid values CSVs must be created for any new attributes with valid values
  • mapping.yml must be updated to ensure update_valid_values.py maps the valid values CSV to the Valid Values column of new attributes
@Bankso Bankso added bug Something isn't working patch PR label for a patch update labels Jul 24, 2024
@Bankso Bankso self-assigned this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch PR label for a patch update
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant