Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolview attribute update #129

Merged
merged 8 commits into from
Jul 25, 2024
Merged

Toolview attribute update #129

merged 8 commits into from
Jul 25, 2024

Conversation

Bankso
Copy link
Contributor

@Bankso Bankso commented Jul 24, 2024

Fixes #128

Changelog

  • Add new attributes to ToolView definition, update dependsOn Component
  • Add valid values CSV for Tool Entity Type. Note that "Consortium" was replaced with "Research Consortium", to address dependencies and prevent attributes from the Consortium model being included in the Tool View schema
  • Add valid values CSV for Tool Entity Role
  • Add valid values for Tool Package Dependencies Present. Added to shared, since boolean valid values can be used in other attributes/models
  • Add valid value mapping for new Tool View attributes
  • Remove Person schema, since we only use Person View and it conflicts with new Tool View valid values
  • Remove Project schema, since we only use Project View and it conflicts with new Tool View valid values

@Bankso
Update annotationProperty.csv
9806134 
Add new attributes to ToolView definition, update dependsOn Component
@Bankso
Create entity_type.csv
7c2112c 
Valid values for Tool Entity Type. Note that "Consortium" was replaced with "Research Consortium", to address dependencies and prevent attributes from the Consortium model being included in the Tool View schema
@Bankso
Create entity_role.csv
a37183a 
Valid values for Tool Entity Role
@Bankso
Create boolean.csv
2bfc9c8 
Valid values for Tool Package Dependencies Present
Added to shared, since boolean valid values can be used in other attributes/models
@Bankso
Update annotationProperty.csv
45c6b44 
Remove Person schema, since we only use Person View and it conflicts with new Tool View valid values
@Bankso
Update annotationProperty.csv
d707795 
Remove Project schema, since we only use Project View and it conflicts with new Tool View valid values
@Bankso
Update mapping.yaml
91c59a4 
Add valid value mapping for new Tool View attributes
@Bankso Bankso added bug Something isn't working non-release PR label for a non-release update labels Jul 24, 2024
@Bankso
Copy link
Contributor Author

Bankso commented Jul 24, 2024

Here's the updated Tool View model in google sheet form: https://docs.google.com/spreadsheets/d/1WyaONXtx7Vf2fxxIC1DDTfOHLoJy6Y7dEFVL5sY7nnw/edit

@Bankso
Copy link
Contributor Author

Bankso commented Jul 24, 2024

@aditigopalan I tagged this as non-release, but it should probably be part of the v7.0.0 version

@aditigopalan
Copy link
Contributor

aditigopalan commented Jul 25, 2024 •
edited
Loading

@aditigopalan I tagged this as non-release, but it should probably be part of the v7.0.0 version

Thank you for working on this! Since 7.0.0 has been released, maybe I will release another version 7.1.0

@aditigopalan aditigopalan merged commit c2cf673 into main Jul 25, 2024
1 check passed
@aditigopalan aditigopalan deleted the toolview-attribute-update branch July 25, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditigopalan aditigopalan aditigopalan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-release PR label for a non-release update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tool View schema definition
2 participants
@Bankso @aditigopalan