+ Prevent Hardcore/Vampirism features inside of Towny Arena Plots. #4
Conversation
|
@nossr50 would you mind giving this a review? |
|
|
||
| @EventHandler | ||
| public void onVampirism(McMMOPlayerVampirismEvent event) { | ||
| TownBlock block = TownyAPI.getInstance().getTownBlock(event.getPlayer().getLocation()); |
There was a problem hiding this comment.
Instead of checking blocks you should be doing a bounds check within the region, what do you think?
There was a problem hiding this comment.
Not sure what you mean by a bounds check, is that something in the McMMO api?
There was a problem hiding this comment.
Ah I think I understand the miscommunication: the units Towny uses as regions are TownBlocks, that API call gets the TownBlock that the player is located in.
There was a problem hiding this comment.
Does towny offer any inBounds() checks for its regions? If not, then I suppose I won't have you go through the trouble of figuring out how to do that yourself.
There was a problem hiding this comment.
The getTownBlock() call is getting the region the player is in, Towny's "regions" are made up of (usually) 16 x 16 x World-Height delimited TownBlocks. The code above is getting the TownBlock that the player is stood in, making sure it's not null (this would mean they're in the Wilderness outside of any Town,) and then it is finding out if the TownBlock has a type of Arena.
This Pull Request adds Arena plot awareness to the mcMMO hardcore features, so that players can voluntarily PVP without losing their valuable levels.
It also updates the pom to use updated repos for the dependencies.
Closes TownyAdvanced/Towny#5806