Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support setting a single element by names/keys #110

Merged
merged 2 commits into from
May 10, 2024

Conversation

aplavin
Copy link
Collaborator

@aplavin aplavin commented May 27, 2022

As I understand, currently there is no way to set a single value specified by names and keys, as in Nc(obs='a', iter=20, :) .= 1000. This PR adds makes it possible.

It makes named dimensions work the same way as unnamed ones: add : when indexing in order to make a view.

@aplavin
Copy link
Collaborator Author

aplavin commented May 27, 2022

nightly test failures seem unrelated

@aplavin aplavin changed the title support view of a single element by names/keys support setting a single element by names/keys Jul 1, 2022
@aplavin
Copy link
Collaborator Author

aplavin commented Jul 1, 2022

bump!

@aplavin
Copy link
Collaborator Author

aplavin commented Jul 30, 2022

bump...

1 similar comment
@aplavin
Copy link
Collaborator Author

aplavin commented Sep 6, 2022

bump...

@aplavin
Copy link
Collaborator Author

aplavin commented Mar 16, 2023

bump! @mcabbott

@aplavin
Copy link
Collaborator Author

aplavin commented May 5, 2023

Bump @mcabbott

1 similar comment
@aplavin
Copy link
Collaborator Author

aplavin commented Jul 13, 2023

Bump @mcabbott

@aplavin
Copy link
Collaborator Author

aplavin commented Aug 16, 2023

bump!

@aplavin
Copy link
Collaborator Author

aplavin commented Mar 7, 2024

semi-yearly bump @mcabbott :)

@aplavin
Copy link
Collaborator Author

aplavin commented Apr 24, 2024

Not sure what's the best way forward here: the package definitely seems maintained, but just very minimally. This and a few other simple small PRs are hanging for a long time without any response.

What could be done to improve the current situation, especially if you @mcabbott don't have too much time for this?

  • transfer somewhere like JuliaArrays
  • fork as AxisKeys2 (or whatever name)
  • make another package AxisKeysExtra (that continues using AxisKeys types and functions) with these and other reasonable changes/extensions

Short-term, I'm leaning towards the last approach, maybe will register such a package soon. Over time, I gathered several other updates (most recently, Makie extension), just didn't bother making new PRs for them while these are hanging anyway.

@aplavin
Copy link
Collaborator Author

aplavin commented May 10, 2024

All failures seem unrelated (they are due to #148), so I guess will merge...

@aplavin aplavin merged commit 550924a into mcabbott:master May 10, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants