Highlight Fixtures feature

[Timebutt]

This PR introduces a new feature into QLC+: the Fixture Tester. With this feature (that you can toggle) with a button in the Fixture Manager selected fixtures will output white light. This is very similar to Chamsys MagicQ's head test, and allows a user to quickly verify a fixture is patched correctly. Walking through the list of all patched fixtures highlights issues in patch. Selecting groups of fixtures will show you if maybe you missed a fixture.

@mcallegari this is my first real feature I add to the codebase, I'm not sure if you can take a quick look and see if I'm heading in the right direction? There's quite a few things I want to add in (the feature is not working for fixtures that require the shutter to be in a certain position, like a Martin Quantum). Selecting groups is also I'd like to add, ... I'd rather get early feedback than finish the entire thing, only to have to redo a lot of it for instance.

I'll provide documentation once the initial implementation is done and before merging obviously ;)

[coveralls]

coverage: 31.905% (-0.06%) from 31.964%
when pulling ea23d00 on Timebutt:add-fixture-tester-feature
into 32fc809 on mcallegari:master.

[yestalgia]

G'day @Timebutt and thanks for this,

This feature sounds similar to the new "Highlight" feature which has been implemented in v5. Perhaps this name is more suitable?

It's important that people don't confuse this feature with the creation of scenes or running the show live. I wonder if it might make sense to automatically "Un-highlight" the fixtures when moving away from the fixtures panel.

The "Highlight" icon in V5 is a lightning bolt, would you be comfortable with me changing it to this? If so, give me access to the branch and I'll happily make the change before this gets merged.

But yeah - a great idea!

Cheers.

[Timebutt]

Hey @yestalgia, thanks for getting back to me so quickly! I updated a few things already following your suggestions: I renamed the feature to Highlight Fixtures to be in line with what v5 will bring. I didn't know a similar feature was already implemented, and would have taken a look had I known ;)

I also updated the code to indeed only highlight fixtures when a user is currently in the Fixture Manager tab, this would lead to very confusing issues otherwise. It's one of the things that was on my to-do list ;)

With regards to the icon: can you point me to that specific lightning bolt? I went through the existing icons but can't seem to find that specific one. I don't know where all QLC+ v5 code is for that matter, is it in a specific branch I am missing?

[mcallegari]

This is the commit
8d91944
and this is the icon, displayed using FontAwesome
https://fontawesome.com/v4/icon/bolt

[yestalgia]

@Timebutt thanks for this again. Can you please merge master and push so I can download a build and test it?

[mcallegari]

@Timebutt I think there's something wrong with the master update. This PR says you modified 369 files. Please review

[Timebutt]

There was definitely something wrong. I have no experience properly rebasing forked repositories to an upstream remote and couldn't get it fixed afterwards, should have gone with a simple merge instead. To fix things, I have created a new clean pull request from a branch where I cherry-picked all relevant commits.

I'm closing this pull request since it's no longer relevant!