Allow multiple ui-content-for for one ui-yield-to #286
Conversation
A use case is having two modals in different templates. Currently, only one modal is shown
|
😳 I ran the test locally and everything went ok! |
Closes #49 Using a second modal ui-yield-to, due to a limitation in mobile-angular-ui See mcasimir/mobile-angular-ui#286
|
@atd if you are referring to travis reporting fail, it is due to it runs tests against phantomjs while they need a real non headless browser, i'm working on it integrating ci with saucelabs or browserstack. Will review it 'by hand' and let you know. Thank u anyway, this is something been requested a lot of times. |
|
@mcasimir yes, it was about Travis Thank you again! |
|
@mcasimir any plans on merging this? |
|
Hi @adt, Sorry it passed one year since the PR. I totally overlooked it once i fixed the tests. And being there since before i opened the board it was very down in the backlog (while usually contributors PRs goes into the in progress column). I'll look into it soon. Hope everything ok on your side. Have a nice evening. |
|
Thank you @mcasimir I hope it is merged soon 😄 |
There are cases when you want having different
ui-content-forfor the sameui-yield-to. An example is having<div ui-yield-to="modals"></div>and defining two modals in different templates.Currently, only one modal is shown
My concern with this patch is the
$compilefunction. Should it be called twice on the same content?