Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #407 #408

Closed
wants to merge 11 commits into from
Closed

Fixes #407 #408

wants to merge 11 commits into from

Conversation

Rouche
Copy link

@Rouche Rouche commented Nov 14, 2016

No description provided.

@mcasimir
Copy link
Owner

Thanks i'll review that asap

Il lun 14 nov 2016, 18:05 Jean-Francois Larouche [email protected]
ha scritto:


You can view, comment on, or merge this pull request online at:

#408
Commit Summary

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#408, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAUcIZ26mxFJlEPrQqE_VxQiNLlHADxtks5q-JS9gaJpZM4Kxjxi
.

@Rouche
Copy link
Author

Rouche commented Nov 14, 2016

No local lint build. Sorry for spam :/

@codecov-io
Copy link

codecov-io commented Nov 14, 2016

Codecov Report

Merging #408 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #408   +/-   ##
=======================================
  Coverage   82.56%   82.56%           
=======================================
  Files          14       14           
  Lines         562      562           
=======================================
  Hits          464      464           
  Misses         98       98

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ec10ac...8b50cc1. Read the comment docs.

@Rouche
Copy link
Author

Rouche commented Nov 22, 2016

Its fully tested now. I forgot a little detail for default behabior sorry.

Little note: i did not commit the dist directory since its done by gulp build but i was unsure if i need to.

@Rouche
Copy link
Author

Rouche commented Jan 16, 2017

Hello!
Any updates? Is this project still maintained?

@mcasimir
Copy link
Owner

mcasimir commented Jan 16, 2017 via email

@Rouche Rouche closed this May 2, 2017
@Rouche
Copy link
Author

Rouche commented May 2, 2017

Ill just continue on fork. Thanks a lot for the lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants