Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few updates (bug fixes, up-to-date build, themed icon, dark mode, material UI, etc.) #74

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

A few updates (bug fixes, up-to-date build, themed icon, dark mode, material UI, etc.) #74

wants to merge 19 commits into from

Conversation

fat-tire
Copy link

Here are a few changes I made to get this working well on Android 15.

Notable changes:

  • Now targets sdk 34 (not yet 35) which required setting a minSdk to 21 instead of 16. Didn't update to targeting sdk 35 as that would mean raising the minSdk to 24.
  • Updated gradle, the libraries, java to 17, etc.
  • Fixed some crashing/other bugs due to deprecations and/or new requirements for mocking location
  • Updated UI to material 3, now supports dark mode
  • added themed icon per [Feature] Support Themed Icon #72 request
  • logs to logcat
  • removed unused code and did a little lint-suggested formatting cleanup.
  • Added note that users may need to disable the wifi/bluetooth-based location sources as they may conflict with this app and cause a "bouncing" effect.

Would be nice TODO:

  • Bring fully to SDK 35 if supporting only more recent Android is okay
  • Maybe update the screenshots (?)

Anyway, feel free to use or edit all/any/no part of this PR. Cheers!

@fat-tire
Bring build ~up-to-date-- targetSDK 34, update library/java/gradle, etc.
9315cc7 
Update app version to 11/1.9.3-beta
Move minsdk update from 16 to 21 (required for some libraries)
Add required USE_EXACT_ALARM permission
ApplyMockBroadcastreceiver doesn't need to be exported apparently
@fat-tire
Remove onPause() check as it's triggered returning from MoreActivity
80968ba 
I think the onDestroy() check is what's really needed.
@fat-tire
Fix more issues w int->long & long->string conversions
c79506e 
Also remove check for older, now unsupported android.
@fat-tire
Remove PendingIntent.FLAG_CANCEL_CURRENT
6a27a0f 
But we still reuse the SCHEDULE_REQUEST_CODE.

This should have the result of canceling/replacing the
current pendingintent.  Using FLAG_CANCEL_CURRENT with FLAG_IMMUTABLE
results in an error.
@fat-tire
Replace e.printStackTrace() with Log.e()
67d4cec
@fat-tire
add missing locale import
9d838fa
@fat-tire
Use getLongVersionCode() as versionCode is deprecated on SDK > P
fad1007 
Extract the version code manually. Dn't think this is actually used
for anything.
@fat-tire
Provide required mockLocation.setElapsedRealtimeNanos
18e5b57
@fat-tire
Remove old/unused code
52a27b8
@fat-tire
Use editor.apply() instead of deprecated editor.commit()
b993e03
@fat-tire
Add forgotten import
55914d7
@fat-tire
Use Material Theme w/MaterialButtons, etc. Supports dark mode
0516ac0 
Don't use custom colors- just use theme defaults.

(previously added the material library)
@fat-tire
support themed launcher icon (per Issue mcastillof#72)
bcff6c0
@fat-tire
One more e.printStackTrace() -> Log.e()
83d98ef
@fat-tire
Lint-suggested code simplifications
ee2186d
@fat-tire
Lint-suggested code formatting
67d64af
@fat-tire
Lint: add final to two variables
8300038
@fat-tire
Update copyright notice to 2018-2024
a179c97
@fat-tire
Update README.md
dd63c7d
@sisuad
Copy link

sisuad commented Dec 17, 2024

nice bro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fat-tire @sisuad