Additional status bar format options #150
Conversation
Allows for more frequent updating of status bar text without polling the Toggl API. So far, allows status bar status to update on the minute, instead of a few seconds later.
No change in functionality, but opens the door to custom format strings.
leoccyao
changed the title
|
Added a number more options for formatting the status bar. Increases the rate at which the status bar text is updated to once per second, though the Toggl API is still polled at the previous rate of every 6 seconds. Partially remediates #5 (oops not #6, which refers to the sidebar), though does not yet allow full customization (a template string with substitutions such as "{project}" "{description}", such as how https://github.com/lukeleppan/better-word-count does it, would be a further improvement) Also ran into the source of the bug for #151 while working on project in status bar! |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
Hi Leo, thanks for your PRs (also #149)!! I really appreciate other people building together on this. I'm a bit in a slow mode when it comes to maintaining my Obsidian plugins, but I will try to take some time out of my schedule the next week or two to properly review and test your code, so that it can merge to |
|
Just wondering if there's any update on when my contribution can be reviewed! |
There was a problem hiding this comment.
Looks pretty good! If you make a few changes I will release this one as well.
Promise I won't leave you hanging for weeks this time!
I'll hold off on releasing 0.12.0 for a moment in case you can resolve this PR this week, then I can bundle the changes together.
|
LGTM, merging this into master and making a release today. Thanks for your contributions!! |
An easy improvement, since the setting already exists. Code for handing numbers very similar to https://github.com/liamcain/obsidian-calendar-plugin/blob/master/src/settings.ts#L108-L122
Also removes a duplicate initiation of a status bar item (which has been creating additional spacing in the status bar)
Edit: also closes #151