perf: use node: prefix to bypass require.cache call for builtins
#496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bit stumped on the test failure. :| |
|
Looks like tests are unhappy prior to this change anyway. Just updated the samples 54c404f, which have no bearing on anything, and the CI fails. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced as part of v16.0.0 and v14.18.0, this allows redundant
require.cachecalls to be bypassed for builtin modules, saving a few yoctoseconds.See https://nodejs.org/api/modules.html#core-modules and discussion in nodejs/node repo regarding why
require.cachecalls are redundant for builtins.