imgtool: Add --pure switch to allow calculating signatures over entire images #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May be interesting for you @taltenbach |
de-nordic
added a commit
to de-nordic/sdk-mcuboot
that referenced
this pull request
Oct 1, 2024
Adds PureEdDSA signature support. The change includes implementation of SIG_PURE TLV that, when present, indicates the signature that is present is Pure type. Upstream PR: mcu-tools/mcuboot#2063 Signed-off-by: Dominik Ermel <[email protected]>
de-nordic
force-pushed
the
support-for-pure-signatures
branch
from
70177ad to
e9e9cf4
Compare
de-nordic
force-pushed
the
support-for-pure-signatures
branch
from
e9e9cf4 to
99bc965
Compare
de-nordic
added a commit
to de-nordic/sdk-mcuboot
that referenced
this pull request
Oct 2, 2024
Adds PureEdDSA signature support. The change includes implementation of SIG_PURE TLV that, when present, indicates the signature that is present is Pure type. Upstream PR: mcu-tools/mcuboot#2063 Signed-off-by: Dominik Ermel <[email protected]>
de-nordic
added a commit
to de-nordic/sdk-mcuboot
that referenced
this pull request
Oct 3, 2024
Adds PureEdDSA signature support. The change includes implementation of SIG_PURE TLV that, when present, indicates the signature that is present is Pure type. Upstream PR: mcu-tools/mcuboot#2063 Signed-off-by: Dominik Ermel <[email protected]>
de-nordic
force-pushed
the
support-for-pure-signatures
branch
2 times, most recently
from
10b5d01 to
e872745
Compare
de-nordic
added a commit
to de-nordic/sdk-mcuboot
that referenced
this pull request
Oct 4, 2024
Adds PureEdDSA signature support. The change includes implementation of SIG_PURE TLV that, when present, indicates the signature that is present is Pure type. Upstream PR: mcu-tools/mcuboot#2063 Signed-off-by: Dominik Ermel <[email protected]>
de-nordic
added a commit
to de-nordic/sdk-mcuboot
that referenced
this pull request
Oct 8, 2024
Adds PureEdDSA signature support. The change includes implementation of SIG_PURE TLV that, when present, indicates the signature that is present is Pure type. Upstream PR: mcu-tools/mcuboot#2063 Signed-off-by: Dominik Ermel <[email protected]>
nvlsianpu
approved these changes
Oct 10, 2024
de-nordic
force-pushed
the
support-for-pure-signatures
branch
from
e872745 to
d3ee8fb
Compare
de-nordic
commented
Oct 10, 2024
| message = digest | ||
| tlv.add(hash_tlv, digest) | ||
| else: | ||
| # Note that when Pure signature is used, hash TLV is not present. |
There was a problem hiding this comment.
@nordicjm @nvlsianpu I am bypassing addition of hash TLV in case when signature is pure; pure signature is not using it, but maybe the hash may be useful for something else is worth leaving it as it is?
There was a problem hiding this comment.
@de-nordic Yes, it might be usefull: Hash is for check the integrity of the image, while the signature is for checking authenticity of the image. Usually HASH calculation is faster and doesn't require any key. I can expect that some cases might require just integrity calculation.
There was a problem hiding this comment.
Now the TLV sha is there, planning, for the future - not here, to add switch to not include it.
de-nordic
added a commit
to de-nordic/sdk-mcuboot
that referenced
this pull request
Oct 10, 2024
Adds PureEdDSA signature support. The change includes implementation of SIG_PURE TLV that, when present, indicates the signature that is present is Pure type. Upstream PR: mcu-tools/mcuboot#2063 Signed-off-by: Dominik Ermel <[email protected]>
de-nordic
force-pushed
the
support-for-pure-signatures
branch
from
d3ee8fb to
2da9e63
Compare
de-nordic
added a commit
to de-nordic/sdk-mcuboot
that referenced
this pull request
Oct 10, 2024
Adds PureEdDSA signature support. The change includes implementation of SIG_PURE TLV that, when present, indicates the signature that is present is Pure type. Upstream PR: mcu-tools/mcuboot#2063 Signed-off-by: Dominik Ermel <[email protected]>
de-nordic
force-pushed
the
support-for-pure-signatures
branch
from
2da9e63 to
bcb1965
Compare
de-nordic
added a commit
to de-nordic/sdk-mcuboot
that referenced
this pull request
Oct 10, 2024
Adds PureEdDSA signature support. The change includes implementation of SIG_PURE TLV that, when present, indicates the signature that is present is Pure type. Upstream PR: mcu-tools/mcuboot#2063 Signed-off-by: Dominik Ermel <[email protected]>
|
@de-nordic I would merge that. Any obstacles? |
nvlsianpu
pushed a commit
to de-nordic/sdk-mcuboot
that referenced
this pull request
Oct 17, 2024
Adds PureEdDSA signature support. The change includes implementation of SIG_PURE TLV that, when present, indicates the signature that is present is Pure type. Upstream PR: mcu-tools/mcuboot#2063 Signed-off-by: Dominik Ermel <[email protected]> Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
pushed a commit
to de-nordic/sdk-mcuboot
that referenced
this pull request
Oct 18, 2024
Adds PureEdDSA signature support. The change includes implementation of SIG_PURE TLV that, when present, indicates the signature that is present is Pure type. Upstream PR: mcu-tools/mcuboot#2063 Signed-off-by: Dominik Ermel <[email protected]> Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
pushed a commit
to de-nordic/sdk-mcuboot
that referenced
this pull request
Oct 19, 2024
Adds PureEdDSA signature support. The change includes implementation of SIG_PURE TLV that, when present, indicates the signature that is present is Pure type. Upstream PR: mcu-tools/mcuboot#2063 Signed-off-by: Dominik Ermel <[email protected]> Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
reviewed
Oct 19, 2024
| tlv.add(hash_tlv, digest) | ||
| self.image_hash = digest |
There was a problem hiding this comment.
self.image_hash is used externally
nvlsianpu
pushed a commit
to nrfconnect/sdk-mcuboot
that referenced
this pull request
Oct 19, 2024
Adds PureEdDSA signature support. The change includes implementation of SIG_PURE TLV that, when present, indicates the signature that is present is Pure type. Upstream PR: mcu-tools/mcuboot#2063 Signed-off-by: Dominik Ermel <[email protected]> Signed-off-by: Andrzej Puzdrowski <[email protected]>
nvlsianpu
force-pushed
the
support-for-pure-signatures
branch
from
df52db5 to
7185bc3
Compare
rlubos
pushed a commit
to rlubos/fw-nrfconnect-mcuboot
that referenced
this pull request
Oct 22, 2024
Adds PureEdDSA signature support. The change includes implementation of SIG_PURE TLV that, when present, indicates the signature that is present is Pure type. Upstream PR: mcu-tools/mcuboot#2063 Signed-off-by: Dominik Ermel <[email protected]> Signed-off-by: Andrzej Puzdrowski <[email protected]> (cherry picked from commit 32a6e8c)
rlubos
pushed a commit
to rlubos/fw-nrfconnect-mcuboot
that referenced
this pull request
Oct 22, 2024
Adds PureEdDSA signature support. The change includes implementation of SIG_PURE TLV that, when present, indicates the signature that is present is Pure type. Upstream PR: mcu-tools/mcuboot#2063 Signed-off-by: Dominik Ermel <[email protected]> Signed-off-by: Andrzej Puzdrowski <[email protected]> (cherry picked from commit 32a6e8c)
de-nordic
force-pushed
the
support-for-pure-signatures
branch
from
7185bc3 to
5ca314d
Compare
|
@de-nordic Should we proceed with this patch? |
|
@d3zd3z can you review? |
jukkar
pushed a commit
to jukkar/sdk-mcuboot
that referenced
this pull request
Dec 5, 2024
Adds PureEdDSA signature support. The change includes implementation of SIG_PURE TLV that, when present, indicates the signature that is present is Pure type. Upstream PR: mcu-tools/mcuboot#2063 Signed-off-by: Dominik Ermel <[email protected]> Signed-off-by: Andrzej Puzdrowski <[email protected]> (cherry picked from commit 32a6e8c) (cherry picked from commit a5786cd)
nvlsianpu
requested changes
Dec 5, 2024
| tlv.add(hash_tlv, digest) | ||
| self.image_hash = digest |
de-nordic
force-pushed
the
support-for-pure-signatures
branch
from
5ca314d to
2916fdd
Compare
nordicjm
force-pushed
the
support-for-pure-signatures
branch
from
2916fdd to
042f458
Compare
Adds PureEdDSA signature support. The change includes implementation of SIG_PURE TLV that, when present, indicates the signature that is present is Pure type. Signed-off-by: Dominik Ermel <[email protected]> Signed-off-by: Mateusz Michalek <[email protected]>
nordicjm
force-pushed
the
support-for-pure-signatures
branch
from
042f458 to
f757950
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds --pure switch to imgtool that allows to run ED25519 over entire image calculating the PureEdDSA signature.
The imgtool will add SIG_PURE TLV as indicator that whatever signature is used is calculated directly over image.
The PR also provides different output for signature verification, where there is signature reported on verification, rather than digest
as digest is no longer available, but will provide digest if key is not provided during verification.Depends on #2029 -- that reserves the SIG_PURE in MCUboot code
Based on #2048