Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allowed hash for ECDSA256P1Public key #2135

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Salamist
Copy link

@Salamist Salamist commented Dec 4, 2024

Hello,

I've found a problem with IMGTOOL when I was trying to inject externally generated signature. (using --fix-sig and --fix-sig-pubkey options)

IMGTOOL was returning an error "Error: Colud not find allowed hash algorithms for <class 'imgtool.keys.ecdsa.ECDSA256P1Public'>"

This PR adds allowed hash (SHA256) for ECC256 Public key.

@Salamist Salamist requested a review from d3zd3z as a code owner December 4, 2024 22:38
@Salamist
Copy link
Author

Salamist commented Dec 9, 2024

I'm sorry, I didn't know I have to sign the commit. I've amended the previous commit to add signature (hopefully :D)

@nordicjm
Copy link
Collaborator

Try doing git commit --amend -s then force push

@nordicjm
Copy link
Collaborator

@Salamist would you be able to fix this today or on Monday? Would like to pull latest changes into Zephyr with a manifest update soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants