Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending UDS message (FF+CF) #278

Merged
merged 20 commits into from
Sep 23, 2024
Merged

Sending UDS message (FF+CF) #278

merged 20 commits into from
Sep 23, 2024

Conversation

mdabrowski1990
Copy link
Owner

Description

Sending of segmented UDS messages over CAN (using python-can package).

How Has This Been Tested?

  • unit tests
  • system tests

NOTE: Bug ticket #228 affects these changes.

Process

I know the process and did my best to follow it

@mdabrowski1990
mark todo
17ff3fd 
Define where changes are required.
Add a few new system tests.
@mdabrowski1990
Update test_python_can.py
5798df4 
Prepare system tests
@mdabrowski1990
simple ff+cf message sending
cd896e0 
- Add creation of Flow Control packets (for the next task =/).
- Define Transmission Error and Waning.
- Core implementation of synchronous sending of FF+CF message.
@mdabrowski1990
add async message sending
7ce29df 
- Implement async message sending
- add checks for n_br_measured
- rework n_cr_measured and n_bs_measured
- add timeout test after ff (detecting fc is received too late)
@mdabrowski1990
updated tests
8b82b49 
- Adjusted expectations in system tests
- Provided examples of timing issues with python-can
@mdabrowski1990
add software tests
1d227a7 
- unit tests for _send_packets_block
- unit tests for _async_send_packets_block
- unit tests for send_message (error handling - unexpected packet and transmission interrupted)
@mdabrowski1990
unit tests
f9a79a9 
Provide all unit tests for sending message feature. Fix a few defects in code.
@mdabrowski1990 mdabrowski1990 added implementation Changes to code CAN Related to CAN specific implementation system tests New test cases for system or system integration testing labels Sep 21, 2024
@mdabrowski1990 mdabrowski1990 self-assigned this Sep 21, 2024
@mdabrowski1990 mdabrowski1990 linked an issue Sep 21, 2024 that may be closed by this pull request
Sending UDS message (FF + CF) #267
Closed
@codecov Codecov
Copy link

codecov bot commented Sep 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9469cad) to head (f23ef76).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #278   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         2425      2503   +78     
  Branches       596       612   +16     
=========================================
+ Hits          2425      2503   +78
Flag Coverage Δ
integration-tests 84.37% <28.48%> (-2.68%) ⬇️
integration-tests-branch 79.30% <27.21%> (-2.51%) ⬇️
unit-tests 100.00% <100.00%> (ø)
unit-tests-branch 100.00% <100.00%> (ø)
Files with missing lines Coverage Δ
uds/segmentation/can_segmenter.py 100.00% <100.00%> (ø)
uds/transport_interface/can_transport_interface.py 100.00% <100.00%> (ø)
uds/utilities/__init__.py 100.00% <100.00%> (ø)
uds/utilities/custom_exceptions.py 100.00% <100.00%> (ø)
uds/utilities/custom_warnings.py 100.00% <100.00%> (ø)

@mdabrowski1990
Update .codecov.yml
4c222a9 
Add target to intergration tests branch coverage as 80% is used.
@mdabrowski1990
Update .codecov.yml
f8e958d 
add flag so comments from bot contain coverage changes
@mdabrowski1990
Update .codecov.yml
ca676fa
@mdabrowski1990
Update .codecov.yml
a0dfd69 
test
@mdabrowski1990
Update .codecov.yml
7a0e777 
must be set :(
mdabrowski1990
mdabrowski1990 commented Sep 21, 2024
View reviewed changes
Copy link
Owner Author

@mdabrowski1990 mdabrowski1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few things to fix.

uds/transport_interface/can_transport_interface.py Outdated Show resolved Hide resolved
uds/transport_interface/can_transport_interface.py Show resolved Hide resolved
uds/transport_interface/can_transport_interface.py Show resolved Hide resolved
uds/transport_interface/can_transport_interface.py Show resolved Hide resolved
uds/transport_interface/can_transport_interface.py Show resolved Hide resolved
tests/system_tests/transport_interface/can_transport_interface/test_python_can.py Outdated Show resolved Hide resolved
tests/system_tests/transport_interface/can_transport_interface/test_python_can.py Outdated Show resolved Hide resolved
tests/system_tests/transport_interface/can_transport_interface/test_python_can.py Outdated Show resolved Hide resolved
uds/transport_interface/can_transport_interface.py Outdated Show resolved Hide resolved
uds/transport_interface/can_transport_interface.py Show resolved Hide resolved
@mdabrowski1990
Fix remarks found during review
25036cd 
- update docstrings
- move and improve n_bs_measured and n_cr_measured to AbstractCanTransportInterface
- add more references to knowledge base
- improve async systemn tests (task handling)
- add missing assertions to unit tests
@mdabrowski1990
Update can_transport_interface.py
f24faa1 
remove needless lines
@mdabrowski1990
add message interruption system tests
3ce4154 
- add system tests with message interrupting another message
- fix async_frames_bugger issue
@mdabrowski1990
Update test_python_can.py
fcda2ac 
Why?
mdabrowski1990
mdabrowski1990 commented Sep 22, 2024
View reviewed changes
Copy link
Owner Author

@mdabrowski1990 mdabrowski1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one serious defect.

tests/system_tests/transport_interface/can_transport_interface/test_python_can.py Outdated Show resolved Hide resolved
@mdabrowski1990
Update config.wcc
dfb2ccd
@mdabrowski1990
fix defect
a1762ab 
Fix defect with asynchronous implementation where in some cases received packets were ignored during message transmission.
@mdabrowski1990
Update can_transport_interface.py
b635ad3
@mdabrowski1990
improve readability
f23ef76 
fixes before PR merging
mdabrowski1990
mdabrowski1990 commented Sep 23, 2024
View reviewed changes
Copy link
Owner Author

@mdabrowski1990 mdabrowski1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdabrowski1990 mdabrowski1990 merged commit c4cd72d into main Sep 23, 2024
61 checks passed
@mdabrowski1990 mdabrowski1990 deleted the sending-uds-message-ff+cf branch September 23, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mdabrowski1990 mdabrowski1990

Labels
CAN Related to CAN specific implementation implementation Changes to code system tests New test cases for system or system integration testing
Projects
None yet
Milestone
4) Message support in CAN Transport I...
Development

Successfully merging this pull request may close these issues.

Sending UDS message (FF + CF)
1 participant
@mdabrowski1990