Dev (#343)

Remove support for serializing RDF/XML "parseType=Collection"
mdesalvo · Oct 6, 2024 · 8cf0354 · 8cf0354
1 parent 1ca7bfe
commit 8cf0354
Show file tree

Hide file tree

Showing 5 changed files with 51 additions and 161 deletions.
diff --git a/RDFSharp.Test/Model/RDFModelUtilitiesTest.cs b/RDFSharp.Test/Model/RDFModelUtilitiesTest.cs
@@ -1223,7 +1223,7 @@ public void ShouldDeserializeSPOCollectionFromGraphExitingOnMissingFirst()
         }
 
         [TestMethod]
-        public void ShouldDeserializeSPOCollectionFromGraphExitingOnInvalidItemType()
+        public void ShouldDeserializeSPOMixedCollectionFromGraph()
         {
             RDFGraph graph = new RDFGraph(
                 [
@@ -1240,9 +1240,10 @@ public void ShouldDeserializeSPOCollectionFromGraphExitingOnInvalidItemType()
             RDFCollection coll1 = RDFModelUtilities.DeserializeCollectionFromGraph(graph, new RDFResource("bnode://coll1/"), RDFModelEnums.RDFTripleFlavors.SPO);
 
             Assert.IsNotNull(coll1);
-            Assert.IsTrue(coll1.ItemsCount == 2);
+            Assert.IsTrue(coll1.ItemsCount == 3);
             Assert.IsTrue(coll1.Items.Any(x => x.Equals(new RDFResource("http://item1/"))));
             Assert.IsTrue(coll1.Items.Any(x => x.Equals(new RDFResource("http://item2/"))));
+            Assert.IsTrue(coll1.Items.Any(x => x.Equals(new RDFPlainLiteral("item3"))));
         }
 
         [TestMethod]
@@ -1257,8 +1258,7 @@ public void ShouldDeserializeEmptySPOCollectionFromGraph()
             RDFCollection coll1 = RDFModelUtilities.DeserializeCollectionFromGraph(graph, new RDFResource("bnode://coll1/"), RDFModelEnums.RDFTripleFlavors.SPO);
 
             Assert.IsNotNull(coll1);
-            Assert.IsTrue(coll1.ItemsCount == 1);
-            Assert.IsTrue(coll1.Items.Any(x => x.Equals(RDFVocabulary.RDF.NIL)));
+            Assert.IsTrue(coll1.ItemsCount == 0);
         }
 
         [TestMethod]
@@ -1378,7 +1378,7 @@ public void ShouldDeserializeSPLCollectionFromGraphExitingOnMissingFirst()
         }
 
         [TestMethod]
-        public void ShouldDeserializeSPLCollectionFromGraphExitingOnInvalidItemType()
+        public void ShouldDeserializeSPLMixedCollectionFromGraph()
         {
             RDFGraph graph = new RDFGraph(
                 [
@@ -1395,9 +1395,10 @@ public void ShouldDeserializeSPLCollectionFromGraphExitingOnInvalidItemType()
             RDFCollection coll1 = RDFModelUtilities.DeserializeCollectionFromGraph(graph, new RDFResource("bnode://coll1/"), RDFModelEnums.RDFTripleFlavors.SPL);
 
             Assert.IsNotNull(coll1);
-            Assert.IsTrue(coll1.ItemsCount == 2);
+            Assert.IsTrue(coll1.ItemsCount == 3);
             Assert.IsTrue(coll1.Items.Any(x => x.Equals(new RDFPlainLiteral("item1"))));
             Assert.IsTrue(coll1.Items.Any(x => x.Equals(new RDFPlainLiteral("item2"))));
+            Assert.IsTrue(coll1.Items.Any(x => x.Equals(new RDFResource("http://item3/"))));
         }
 
         [TestMethod]
@@ -1412,7 +1413,8 @@ public void ShouldDeserializeEmptySPLCollectionFromGraph()
             RDFCollection coll1 = RDFModelUtilities.DeserializeCollectionFromGraph(graph, new RDFResource("bnode://coll1/"), RDFModelEnums.RDFTripleFlavors.SPL);
 
             Assert.IsNotNull(coll1);
-            Assert.IsTrue(coll1.ItemsCount == 0);        }
+            Assert.IsTrue(coll1.ItemsCount == 0);
+        }
 
         [TestMethod]
         public void ShouldDetectSPOCollectionFlavorFromGraph()