Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test that app has ota and ota has listeners for OTA operations #226

Merged
merged 4 commits into from
Jul 30, 2024

Conversation

systemcrash
Copy link
Contributor

Apparently in some situations they're absent. Let's guard against them.

Closes issue #225

Copy link

@frli4797 frli4797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit seems to have to have two syntax errors with double colons on conditional statements. (Typo?) I've tried you PR with just removing these, which worked fine.

custom_components/zha_toolkit/ota.py Outdated Show resolved Hide resolved
custom_components/zha_toolkit/ota.py Outdated Show resolved Hide resolved
Apparently in some situations they're absent. Let's guard against them.

Closes issue mdeweerd#225
@mdeweerd mdeweerd merged commit fecf8ae into mdeweerd:main Jul 30, 2024
4 checks passed
@mdeweerd
Copy link
Owner

I've been quite busy for a while, I have just integrated this and making a release with the updates.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants