-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/keeplocalcopy #584
Open
HobieCat
wants to merge
37
commits into
mdjnelson:MOODLE_402_STABLE
Choose a base branch
from
HobieCat:feature/keeplocalcopy
base: MOODLE_402_STABLE
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/keeplocalcopy #584
HobieCat
wants to merge
37
commits into
mdjnelson:MOODLE_402_STABLE
from
HobieCat:feature/keeplocalcopy
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry I haven't been able to look at this until now. Can you rebase and then solve the issues reported by GHA? Thanks for your hard work. |
…d_customcert into feature/keeplocalcopy
Hi, looks like I've fixed the issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
I've added the feature to save generated PDF to the local filesystem, and to serve them when downloading.
It came from a customer request to have a (sort of) archived PDF certificates at the time it was first viewed/generated.
Also, a 'download all certificates' link was added to the navigation menus of the course (to download a zip with all of the course certificates) and the activity itself (to download all the certificates of the single activity).
If of any interest to anyone, please merge at your convenience.