Add Feature-Policy:web-share #6979
Conversation
github-actions
bot
added
the
data:http 🚠
|
@ddbeck Is this something you might look at? |
There was a problem hiding this comment.
Thanks for this PR, @hamishwillee. A few comments in line comments. Also, could you link to a bug or test or something to substantiate the Firefox implementation claim? It's nice to have a record of why set values to what we did. Thank you!
http/headers/feature-policy.json
Outdated
| "mdn_url": "https://developer.mozilla.org/docs/Web/HTTP/Headers/Feature-Policy/web-share", | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": null |
There was a problem hiding this comment.
This appears to have not yet shipped in Chromium: https://www.chromestatus.com/feature/6362499966304256. I'd apply this change to all the Chromium browsers (Chrome, Edge, Opera, Samsung Internet, and WebView)
| "version_added": null | |
| "version_added": false |
There was a problem hiding this comment.
Fixed (and rebased). Thank you!
http/headers/feature-policy.json
Outdated
| "version_added": null | ||
| }, | ||
| "safari": { | ||
| "version_added": null |
There was a problem hiding this comment.
I couldn't find evidence that WebKit has implemented this: https://bugs.webkit.org/show_bug.cgi?id=214448. I'd set both Safaris to false too.
hamishwillee
force-pushed
the
feature_policy-web_share
branch
from
59d3792
to
0c4f1fe
Compare
Co-authored-by: Daniel D. Beck <[email protected]>
hamishwillee
force-pushed
the
feature_policy-web_share
branch
from
f03b121
to
fe30bdd
Compare
|
Hi @ddbeck
Isn't that the bug report you thought we should remove? https://bugzilla.mozilla.org/show_bug.cgi?id=1653199 |
|
Sorry for being unclear, @hamishwillee. I meant to ask for you to link to the bug in the PR description—not the notes.
Ah, this is the key thing. Thank you! Your original note linked to bug 1653481, ("[Meta] Implement and maintain WebShare API"). This new bug 1653199 ("Web Share should be controlled by permission policy"), is what I was thinking of for the PR record keeping. I just needed something, apart from the diff, which claimed that the stuff in the diff was true. 😄 |
This confirms Feature-Policy web-share is supported in FF81 but makes the note that the protected feature (Web Share API) is itself not implemented. The bug that should track the implementation is included in that note.
I have set the other browsers as
null. It is possible that some of them do support this, but there is no obvious information and no easy way to test (i.e. to test would take more effort than knowing would be worth).