Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec_url data in html/global_attributes.json #8064

Merged

Conversation

sideshowbarker
Copy link
Collaborator

This change adds spec URLs in html/global_attributes.json for all global attributes that have an mdn_url for an MDN article with a Specification(s) table — with the exception that no spec data is added for any cases where a URL found in an MDN Specification(s) table has no fragment-ID part. Relates to #6765.

This change adds spec URLs in html/global_attributes.json for all global
attributes that have an mdn_url for an MDN article with a Specification(s)
table — with the exception that no spec data is added for any cases where
a URL found in an MDN Specification(s) table has no fragment-ID part.
@github-actions github-actions bot added the data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Dec 20, 2020
@Elchi3 Elchi3 self-requested a review December 20, 2020 09:59
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start, thank you! I have some comments to bring in some consistency here but I also see that the spec is not always consistent, so some things are probably fine as is. Also, I realize this is from scraping the wiki, so some choices weren't made by you :-) Let me know what you think!

html/global_attributes.json Outdated Show resolved Hide resolved
html/global_attributes.json Outdated Show resolved Hide resolved
html/global_attributes.json Show resolved Hide resolved
html/global_attributes.json Outdated Show resolved Hide resolved
html/global_attributes.json Outdated Show resolved Hide resolved
html/global_attributes.json Outdated Show resolved Hide resolved
html/global_attributes.json Outdated Show resolved Hide resolved
html/global_attributes.json Outdated Show resolved Hide resolved
@sideshowbarker
Copy link
Collaborator Author

OK, I think I’ve now responded to all review comments, and committed all the suggestions. So if this now looks good, we can merge and move on to the next batch (and if so, let me know what you think that should be).

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think I’ve now responded to all review comments, and committed all the suggestions. So if this now looks good, we can merge and move on to the next batch (and if so, let me know what you think that should be).

Thanks! I'm also happy to help with PRs or review anything you submit. Whatever you think is most effective, really.

I'd continue in the html/ folder. Maybe manifest/ next then elements/ (in chunks if needed)?

@Elchi3 Elchi3 merged commit 24d24a9 into mdn:master Dec 20, 2020
@sideshowbarker sideshowbarker deleted the sideshowbarker/html-global-attributes-add-spec-urls branch December 20, 2020 17:18
chrisdavidmills pushed a commit to mdn/content that referenced this pull request Dec 28, 2020
* Update global attributes spec URLs to match BCD

This change aligns the MDN spec URL values for HTML global attributes to
sync with the spec URL data we have in BCD.

See mdn/browser-compat-data#8064 for discussion
on the changes we made to some of the URLs when we added them to BCD.

* Update files/en-us/web/html/attributes/autocomplete/index.html

Co-authored-by: Florian Scholz <[email protected]>

Co-authored-by: Florian Scholz <[email protected]>
barhenthv added a commit to barhenthv/content that referenced this pull request Aug 2, 2024
* Update global attributes spec URLs to match BCD

This change aligns the MDN spec URL values for HTML global attributes to
sync with the spec URL data we have in BCD.

See mdn/browser-compat-data#8064 for discussion
on the changes we made to some of the URLs when we added them to BCD.

* Update files/en-us/web/html/attributes/autocomplete/index.html

Co-authored-by: Florian Scholz <[email protected]>

Co-authored-by: Florian Scholz <[email protected]>
Stolla00 added a commit to Stolla00/content that referenced this pull request Aug 10, 2024
* Update global attributes spec URLs to match BCD

This change aligns the MDN spec URL values for HTML global attributes to
sync with the spec URL data we have in BCD.

See mdn/browser-compat-data#8064 for discussion
on the changes we made to some of the URLs when we added them to BCD.

* Update files/en-us/web/html/attributes/autocomplete/index.html

Co-authored-by: Florian Scholz <[email protected]>

Co-authored-by: Florian Scholz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants