Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put browser-compat info in front-runner for api/[jkl]* #5413

Merged
merged 1 commit into from
May 31, 2021
Merged

Put browser-compat info in front-runner for api/[jkl]* #5413

merged 1 commit into from
May 31, 2021

Conversation

teoli2003
Copy link
Contributor

What was wrong/why is this fix needed? (quick summary only)

We want to have browser-compat in front-runner: this allows us to write {{Compat}} without parameter, and in the future, {{Spec}} (and likely more).

This PR covers api/[jkl]* for the case without problem: 1 macro Compat in the page and its parameter matching the slug. Other cases (no Compat macros on a page, multiple Compat macros, macro not matching the slug, will be done at a later stage).

MDN URL of the main page changed

69 files in api/*

Issue number (if there is an associated issue)

openwebdocs/project#36

Anything else that could help us review it

@teoli2003 teoli2003 requested a review from a team as a code owner May 28, 2021 08:44
@teoli2003 teoli2003 requested review from wbamberg and removed request for a team May 28, 2021 08:44
@teoli2003 teoli2003 mentioned this pull request May 28, 2021
Closed
51 tasks
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 39 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/KeyboardEvent
Title: KeyboardEvent
on GitHub
Flaw count: 4

  • macros:
    • /en-us/docs/web/api/keyevent (url: /en-US/docs/Web/API/KeyEvent) does not exist
    • /en-US/docs/Web/API/KeyboardEvent/locale does not exist
    • /en-US/docs/Web/API/KeyboardEvent/char does not exist
    • /en-US/docs/Web/API/KeyboardEvent/keyLocation does not exist

URL: /en-US/docs/Web/API/KeyboardEvent/KeyboardEvent
Title: KeyboardEvent()
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/keyevent (url: /en-US/docs/Web/API/KeyEvent) does not exist

URL: /en-US/docs/Web/API/KeyboardEvent/code
Title: KeyboardEvent.code
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/keyevent (url: /en-US/docs/Web/API/KeyEvent) does not exist

URL: /en-US/docs/Web/API/KeyboardEvent/repeat
Title: KeyboardEvent.repeat
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/keyevent (url: /en-US/docs/Web/API/KeyEvent) does not exist

URL: /en-US/docs/Web/API/KeyboardEvent/ctrlKey
Title: KeyboardEvent.ctrlKey
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/keyevent (url: /en-US/docs/Web/API/KeyEvent) does not exist

URL: /en-US/docs/Web/API/KeyboardEvent/isComposing
Title: KeyboardEvent.isComposing
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/keyevent (url: /en-US/docs/Web/API/KeyEvent) does not exist

URL: /en-US/docs/Web/API/KeyboardEvent/which
Title: KeyboardEvent.which
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/keyevent (url: /en-US/docs/Web/API/KeyEvent) does not exist

URL: /en-US/docs/Web/API/KeyboardEvent/key
Title: KeyboardEvent.key
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/keyevent (url: /en-US/docs/Web/API/KeyEvent) does not exist

URL: /en-US/docs/Web/API/KeyboardEvent/keyCode
Title: KeyboardEvent.keyCode
on GitHub
Flaw count: 2

  • macros:
    • /en-us/docs/web/api/keyevent (url: /en-US/docs/Web/API/KeyEvent) does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Gecko_Keypress_Event

URL: /en-US/docs/Web/API/KeyboardEvent/shiftKey
Title: KeyboardEvent.shiftKey
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/keyevent (url: /en-US/docs/Web/API/KeyEvent) does not exist

URL: /en-US/docs/Web/API/KeyboardEvent/metaKey
Title: KeyboardEvent.metaKey
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/keyevent (url: /en-US/docs/Web/API/KeyEvent) does not exist

URL: /en-US/docs/Web/API/KeyboardEvent/charCode
Title: KeyboardEvent.charCode
on GitHub
Flaw count: 2

  • macros:
    • /en-us/docs/web/api/keyevent (url: /en-US/docs/Web/API/KeyEvent) does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Gecko_Keypress_Event

URL: /en-US/docs/Web/API/KeyboardEvent/location
Title: KeyboardEvent.location
on GitHub
Flaw count: 2

  • macros:
    • /en-us/docs/web/api/keyevent (url: /en-US/docs/Web/API/KeyEvent) does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Mozilla/Boot_to_Gecko

URL: /en-US/docs/Web/API/KeyboardEvent/keyIdentifier
Title: KeyboardEvent.keyIdentifier
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/keyevent (url: /en-US/docs/Web/API/KeyEvent) does not exist

URL: /en-US/docs/Web/API/KeyboardEvent/getModifierState
Title: KeyboardEvent.getModifierState()
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/keyevent (url: /en-US/docs/Web/API/KeyEvent) does not exist

URL: /en-US/docs/Web/API/KeyboardEvent/altKey
Title: KeyboardEvent.altKey
on GitHub
Flaw count: 1

  • macros:
    • /en-us/docs/web/api/keyevent (url: /en-US/docs/Web/API/KeyEvent) does not exist

URL: /en-US/docs/Web/API/LocalFileSystemSync
Title: LocalFileSystemSync
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: api.LocalFileSystemSync

URL: /en-US/docs/Web/API/LocalFileSystemSync/requestFileSystemSync
Title: LocalFileSystemSync.requestFileSystemSync()
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/LocalFileSystem/requestFileSystem does not exist
  • broken_links:
    • Is currently http:// but can become https://
  • bad_bcd_queries:
    • No BCD data for query: api.LocalFileSystemSync.requestFileSystemSync

URL: /en-US/docs/Web/API/LargestContentfulPaint
Title: LargestContentfulPaint
on GitHub
Flaw count: 14

  • macros:
    • /en-US/docs/Web/API/LargestContentfulPaint/element does not exist
    • /en-US/docs/Web/API/LargestContentfulPaint/renderTime does not exist
    • /en-US/docs/Web/API/LargestContentfulPaint/loadTime does not exist
    • /en-US/docs/Web/API/LargestContentfulPaint/size does not exist
    • /en-US/docs/Web/API/LargestContentfulPaint/id does not exist
    • and 2 more flaws omitted
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 2 more flaws omitted

URL: /en-US/docs/Web/API/KeyframeEffect
Title: KeyframeEffect
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/KeyframeEffect/pseudoElement does not exist
  • broken_links:
    • Is currently http:// but can become https://
  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/API/KeyframeEffect/KeyframeEffect
Title: KeyframeEffect.KeyframeEffect()
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/KeyframeEffectReadOnly/KeyframeEffectReadOnly redirects to /en-US/docs/Web/API/KeyframeEffect/KeyframeEffect
    • /en-US/docs/Web/API/KeyframeEffectReadOnly/KeyframeEffectReadOnly redirects to /en-US/docs/Web/API/KeyframeEffect/KeyframeEffect
  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/API/KeyframeEffect/target
Title: KeyframeEffect.target
on GitHub
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/API/KeyframeEffect/getKeyframes
Title: KeyframeEffect.getKeyframes()
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/KeyframeEffect/spacing does not exist
    • /en-US/docs/Web/API/KeyframeEffect/spacing does not exist
  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/API/LockManager
Title: LockManager
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/LockManagerSnapshot does not exist

URL: /en-US/docs/Web/API/LinkStyle
Title: LinkStyle
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/LinkStyle/sheet does not exist
    • /en-US/docs/Web/API/LinkStyle/sheet does not exist
  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/API/LayoutShift
Title: LayoutShift
on GitHub
Flaw count: 9

  • macros:
    • /en-US/docs/Web/API/LayoutShift/value does not exist
    • /en-US/docs/Web/API/LayoutShift/hadRecentInput does not exist
    • /en-US/docs/Web/API/LayoutShift/lastInputTime does not exist
    • /en-US/docs/Web/API/LayoutShift/sources does not exist
    • /en-US/docs/Web/API/LayoutShift/toJSON does not exist
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/KeyframeEffectOptions
Title: KeyframeEffectOptions
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/KeyframeEffectReadOnly/KeyframeEffectReadOnly redirects to /en-US/docs/Web/API/KeyframeEffect/KeyframeEffect
    • /en-US/docs/Web/API/KeyframeEffectReadOnly/KeyframeEffectReadOnly redirects to /en-US/docs/Web/API/KeyframeEffect/KeyframeEffect
  • bad_bcd_queries:
    • No BCD data for query: api.KeyframeEffectOptions

URL: /en-US/docs/Web/API/Location
Title: Location
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/HTMLHyperlinkElementUtils does not exist

URL: /en-US/docs/Web/API/LayoutShiftAttribution
Title: LayoutShiftAttribution
on GitHub
Flaw count: 7

  • macros:
    • /en-US/docs/Web/API/LayoutShiftAttribution/Node does not exist
    • /en-US/docs/Web/API/LayoutShiftAttribution/previousRect does not exist
    • /en-US/docs/Web/API/LayoutShiftAttribution/currentRect does not exist
  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!

URL: /en-US/docs/Web/API/LocalFileSystem
Title: LocalFileSystem
on GitHub
Flaw count: 2

  • broken_links:
    • Is currently http:// but can become https://
  • bad_bcd_queries:
    • No BCD data for query: api.LocalFileSystem

External URLs

URL: /en-US/docs/Web/API/LinearAccelerationSensor
Title: LinearAccelerationSensor
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/LinearAccelerationSensor/LinearAccelerationSensor
Title: LinearAccelerationSensor.LinearAccelerationSensor()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Lock
Title: Lock
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Lock/mode
Title: Locks.mode
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Lock/name
Title: Locks.name
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardEvent
Title: KeyboardEvent
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardEvent/KeyboardEvent
Title: KeyboardEvent()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardEvent/code
Title: KeyboardEvent.code
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardEvent/repeat
Title: KeyboardEvent.repeat
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardEvent/ctrlKey
Title: KeyboardEvent.ctrlKey
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardEvent/isComposing
Title: KeyboardEvent.isComposing
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardEvent/which
Title: KeyboardEvent.which
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardEvent/key
Title: KeyboardEvent.key
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardEvent/keyCode
Title: KeyboardEvent.keyCode
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardEvent/shiftKey
Title: KeyboardEvent.shiftKey
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardEvent/metaKey
Title: KeyboardEvent.metaKey
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardEvent/charCode
Title: KeyboardEvent.charCode
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardEvent/location
Title: KeyboardEvent.location
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardEvent/keyIdentifier
Title: KeyboardEvent.keyIdentifier
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardEvent/getModifierState
Title: KeyboardEvent.getModifierState()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardEvent/altKey
Title: KeyboardEvent.altKey
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/LocalMediaStream
Title: LocalMediaStream
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/LocalFileSystemSync
Title: LocalFileSystemSync
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/LocalFileSystemSync/requestFileSystemSync
Title: LocalFileSystemSync.requestFileSystemSync()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/LargestContentfulPaint
Title: LargestContentfulPaint
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyframeEffect
Title: KeyframeEffect
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyframeEffect/setKeyframes
Title: KeyframeEffect.setKeyframes()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyframeEffect/composite
Title: KeyframeEffect.composite
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyframeEffect/KeyframeEffect
Title: KeyframeEffect.KeyframeEffect()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyframeEffect/iterationComposite
Title: KeyframeEffect.iterationComposite
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyframeEffect/target
Title: KeyframeEffect.target
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyframeEffect/getKeyframes
Title: KeyframeEffect.getKeyframes()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/LockManager
Title: LockManager
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/LockManager/query
Title: LockManager.query()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/LockManager/request
Title: LockManager.request()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/LinkStyle
Title: LinkStyle
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/LayoutShift
Title: LayoutShift
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardLayoutMap
Title: KeyboardLayoutMap
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardLayoutMap/forEach
Title: KeyboardLayoutMap.forEach()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardLayoutMap/has
Title: KeyboardLayoutMap.has()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardLayoutMap/size
Title: KeyboardLayoutMap.size
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardLayoutMap/entries
Title: KeyboardLayoutMap.entries
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardLayoutMap/values
Title: KeyboardLayoutMap.values
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardLayoutMap/keys
Title: KeyboardLayoutMap.keys
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyboardLayoutMap/get
Title: KeyboardLayoutMap.get()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KeyframeEffectOptions
Title: KeyframeEffectOptions
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Location
Title: Location
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Location/ancestorOrigins
Title: Location: ancestorOrigins
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Location/pathname
Title: Location: pathname
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Location/hash
Title: Location: hash
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Location/protocol
Title: Location: protocol
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Location/username
Title: Location: username
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Location/assign
Title: Location: assign()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Location/port
Title: Location: port
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Location/toString
Title: Location: toString()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Location/replace
Title: Location: replace()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Location/reload
Title: Location: reload()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Location/origin
Title: Location: origin
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Location/hostname
Title: Location: hostname
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Location/search
Title: Location: search
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Location/href
Title: Location: href
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Location/host
Title: Location: host
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Location/password
Title: Location: password
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/LayoutShiftAttribution
Title: LayoutShiftAttribution
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/KHR_parallel_shader_compile
Title: KHR_parallel_shader_compile
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Keyboard
Title: Keyboard
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Keyboard/lock
Title: Keyboard.lock()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/Keyboard/getLayoutMap
Title: Keyboard.getLayoutMap()
on GitHub

No new external URLs

URL: /en-US/docs/Web/API/LocalFileSystem
Title: LocalFileSystem
on GitHub

No new external URLs

Elchi3
Elchi3 approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Elchi3 Elchi3 merged commit b06b69b into mdn:main May 31, 2021
@teoli2003 teoli2003 deleted the move-browser-compat-in-front-runner-api-jkl branch May 31, 2021 18:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoli2003 @Elchi3