Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put browser-compat info in front-runner for http/headers/CSP #5468

Merged
merged 1 commit into from
May 31, 2021
Merged

Put browser-compat info in front-runner for http/headers/CSP #5468

merged 1 commit into from
May 31, 2021

Conversation

teoli2003
Copy link
Contributor

What was wrong/why is this fix needed? (quick summary only)

We want to have browser-compat in front-runner: this allows us to write {{Compat}} without parameter, and in the future, {{Spec}} (and likely more).

This PR covers http/headers/Content-Security-Policy for the case without problem: 1 macro Compat in the page and its parameter matching the slug. Other cases (no Compat macros on a page, multiple Compat macros, macro not matching the slug, will be done at a later stage).

MDN URL of the main page changed

32 files in api/*

Issue number (if there is an associated issue)

openwebdocs/project#36

Anything else that could help us review it

@teoli2003 teoli2003 requested a review from a team as a code owner May 30, 2021 08:36
@teoli2003 teoli2003 requested review from mirunacurtean and removed request for a team May 30, 2021 08:36
@teoli2003 teoli2003 mentioned this pull request May 30, 2021
Closed
51 tasks
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 28 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy
Title: Content-Security-Policy
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Glossary/XSS redirects to /en-US/docs/Glossary/Cross-site_scripting
    • /en-US/docs/Web/API/Window/execScript does not exist

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/script-src
Title: CSP: script-src
on GitHub
Flaw count: 1

  • macros:
    • /en-US/docs/Web/API/Window/execScript does not exist

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/default-src
Title: CSP: default-src
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/Guide/Events/Event_handlers

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/frame-ancestors
Title: CSP: frame-ancestors
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/URIs_and_URLs

External URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy
Title: Content-Security-Policy
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/navigate-to
Title: CSP: navigate-to
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/font-src
Title: CSP: font-src
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/script-src-attr
Title: CSP: script-src-attr
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/manifest-src
Title: CSP: manifest-src
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/base-uri
Title: CSP: base-uri
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/script-src
Title: CSP: script-src
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/trusted-types
Title: CSP: trusted-types
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/img-src
Title: CSP: img-src
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/frame-src
Title: CSP: frame-src
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/prefetch-src
Title: CSP: prefetch-src
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/style-src-attr
Title: CSP: style-src-attr
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/style-src
Title: CSP: style-src
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/upgrade-insecure-requests
Title: CSP: upgrade-insecure-requests
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/block-all-mixed-content
Title: CSP: block-all-mixed-content
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/style-src-elem
Title: CSP: style-src-elem
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/sandbox
Title: CSP: sandbox
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/form-action
Title: CSP: form-action
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/require-trusted-types-for
Title: CSP: require-trusted-types-for
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/media-src
Title: CSP: media-src
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/script-src-elem
Title: CSP: script-src-elem
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/referrer
Title: CSP: referrer
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/connect-src
Title: CSP: connect-src
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/object-src
Title: CSP: object-src
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/report-to
Title: CSP: report-to
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/report-uri
Title: CSP: report-uri
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/plugin-types
Title: CSP: plugin-types
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/child-src
Title: CSP: child-src
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/require-sri-for
Title: CSP: require-sri-for
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/default-src
Title: CSP: default-src
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/frame-ancestors
Title: CSP: frame-ancestors
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Headers/Content-Security-Policy/worker-src
Title: CSP: worker-src
on GitHub

No new external URLs

hamishwillee
hamishwillee approved these changes May 31, 2021
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Thanks.

@hamishwillee hamishwillee merged commit 703707a into mdn:main May 31, 2021
@teoli2003 teoli2003 deleted the move-browser-compat-in-front-runner-http-csp branch May 31, 2021 04:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@mirunacurtean mirunacurtean Awaiting requested review from mirunacurtean

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoli2003 @hamishwillee