Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put browser-compat info in front-runner for http/status/* #5470

Merged
merged 1 commit into from
May 31, 2021
Merged

Put browser-compat info in front-runner for http/status/* #5470

merged 1 commit into from
May 31, 2021

Conversation

teoli2003
Copy link
Contributor

What was wrong/why is this fix needed? (quick summary only)

We want to have browser-compat in front-runner: this allows us to write {{Compat}} without parameter, and in the future, {{Spec}} (and likely more).

This PR covers http/status/* for the case without problem: 1 macro Compat in the page and its parameter matching the slug. Other cases (no Compat macros on a page, multiple Compat macros, macro not matching the slug, will be done at a later stage).

MDN URL of the main page changed

30 files in api/*

Issue number (if there is an associated issue)

openwebdocs/project#36

Anything else that could help us review it

@teoli2003 teoli2003 requested a review from a team as a code owner May 30, 2021 09:42
@teoli2003 teoli2003 requested review from mirunacurtean and removed request for a team May 30, 2021 09:42
@teoli2003 teoli2003 mentioned this pull request May 30, 2021
Closed
51 tasks
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 27 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTTP/Status/404
Title: 404 Not Found
on GitHub
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/404

URL: /en-US/docs/Web/HTTP/Status/402
Title: 402 Payment Required
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: http.status.402

URL: /en-US/docs/Web/HTTP/Status/103
Title: 103 Early Hints
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: http.status.103

External URLs

URL: /en-US/docs/Web/HTTP/Status/303
Title: 303 See Other
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/206
Title: 206 Partial Content
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/302
Title: 302 Found
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/500
Title: 500 Internal Server Error
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/404
Title: 404 Not Found
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/100
Title: 100 Continue
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/201
Title: 201 Created
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/402
Title: 402 Payment Required
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/410
Title: 410 Gone
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/406
Title: 406 Not Acceptable
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/308
Title: 308 Permanent Redirect
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/416
Title: 416 Range Not Satisfiable
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/403
Title: 403 Forbidden
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/200
Title: 200 OK
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/502
Title: 502 Bad Gateway
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/504
Title: 504 Gateway Timeout
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/503
Title: 503 Service Unavailable
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/501
Title: 501 Not Implemented
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/401
Title: 401 Unauthorized
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/304
Title: 304 Not Modified
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/204
Title: 204 No Content
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/103
Title: 103 Early Hints
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/425
Title: 425 Too Early
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/307
Title: 307 Temporary Redirect
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/451
Title: 451 Unavailable For Legal Reasons
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/407
Title: 407 Proxy Authentication Required
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/409
Title: 409 Conflict
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/418
Title: 418 I'm a teapot
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/301
Title: 301 Moved Permanently
on GitHub

No new external URLs

URL: /en-US/docs/Web/HTTP/Status/412
Title: 412 Precondition Failed
on GitHub

No new external URLs

Elchi3
Elchi3 approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Elchi3 Elchi3 merged commit 6cc107b into mdn:main May 31, 2021
@teoli2003 teoli2003 deleted the move-browser-compat-in-front-runner-http-status branch May 31, 2021 18:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

@mirunacurtean mirunacurtean Awaiting requested review from mirunacurtean

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoli2003 @Elchi3