Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put browser-compat info in front-runner for http/methods/* #5472

Merged

Conversation

teoli2003
Copy link
Contributor

What was wrong/why is this fix needed? (quick summary only)

We want to have browser-compat in front-runner: this allows us to write {{Compat}} without parameter, and in the future, {{Spec}} (and likely more).

This PR covers http/methods (and data_url) for the case without problem: 1 macro Compat in the page and its parameter matching the slug. Other cases (no Compat macros on a page, multiple Compat macros, macro not matching the slug, will be done at a later stage).

MDN URL of the main page changed

10 files in http/*

Issue number (if there is an associated issue)

openwebdocs/project#36

Anything else that could help us review it

@teoli2003 teoli2003 requested a review from a team as a code owner May 30, 2021 11:36
@teoli2003 teoli2003 requested review from mirunacurtean and removed request for a team May 30, 2021 11:36
@github-actions
Copy link
Contributor

Preview URLs

Flaws

None! 🎉

External URLs

URL: /en-US/docs/Web/HTTP/Methods
Title: HTTP request methods
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Methods/POST
Title: POST
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Methods/HEAD
Title: HEAD
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Methods/DELETE
Title: DELETE
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Methods/PUT
Title: PUT
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Methods/TRACE
Title: TRACE
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Methods/OPTIONS
Title: OPTIONS
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Methods/CONNECT
Title: CONNECT
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Methods/GET
Title: GET
on GitHub

No new external URLs


URL: /en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URIs
Title: Data URLs
on GitHub

No new external URLs

@teoli2003 teoli2003 changed the title Move browser compat in front runner http methods Put browser compat in front runner http methods May 30, 2021
@teoli2003 teoli2003 changed the title Put browser compat in front runner http methods Put browser compat info in front-runner http methods May 30, 2021
@teoli2003 teoli2003 changed the title Put browser compat info in front-runner http methods Put browser compat info in front-runner for http/methods/* May 31, 2021
@teoli2003 teoli2003 changed the title Put browser compat info in front-runner for http/methods/* Put browser-compat info in front-runner for http/methods/* May 31, 2021
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Elchi3 Elchi3 merged commit e765834 into mdn:main May 31, 2021
@teoli2003 teoli2003 deleted the move-browser-compat-in-front-runner-http-methods branch May 31, 2021 18:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants