Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put browser-compat info in front-runner for webextensions/manifest.json/* #5492

Merged
merged 2 commits into from
May 31, 2021
Merged

Put browser-compat info in front-runner for webextensions/manifest.json/* #5492

merged 2 commits into from
May 31, 2021

Conversation

teoli2003
Copy link
Contributor

What was wrong/why is this fix needed? (quick summary only)

We want to have browser-compat in front-runner: this allows us to write {{Compat}} without parameter, and in the future, {{Spec}} (and likely more).

This PR covers webextensions/manifest.json/* for the case without problem: 1 macro Compat in the page and its parameter matching the slug. Other cases (no Compat macros on a page, multiple Compat macros, macro not matching the slug, will be done at a later stage).

MDN URL of the main page changed

33 files in api/*

Issue number (if there is an associated issue)

openwebdocs/project#36

Anything else that could help us review it

@teoli2003 teoli2003 requested a review from a team as a code owner May 31, 2021 04:45
@teoli2003 teoli2003 requested review from zombie and removed request for a team May 31, 2021 04:45
@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2021 •
edited
Loading

Preview URLs

Flaws

Note! 29 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Match_patterns
Title: Match patterns in extension manifests
on GitHub
Flaw count: 1

  • broken_links:
    • No need for the pathname in anchor links if it's the same page

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/user_scripts
Title: user_scripts
on GitHub
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/dictionaries
Title: dictionaries
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: webextensions.manifest.dictionaries

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/permissions
Title: permissions
on GitHub
Flaw count: 2

  • broken_links:
    • No need for the pathname in anchor links if it's the same page
    • No need for the pathname in anchor links if it's the same page

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/content_scripts
Title: content_scripts
on GitHub
Flaw count: 6

  • broken_links:
    • No need for the pathname in anchor links if it's the same page
    • No need for the pathname in anchor links if it's the same page
    • No need for the pathname in anchor links if it's the same page
    • No need for the pathname in anchor links if it's the same page
    • No need for the pathname in anchor links if it's the same page
    • and 1 more flaws omitted

External URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Match_patterns
Title: Match patterns in extension manifests
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json
Title: manifest.json
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/externally_connectable
Title: externally_connectable
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/theme_experiment
Title: theme_experiment
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/options_ui
Title: options_ui
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/version
Title: version
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/user_scripts
Title: user_scripts
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/web_accessible_resources
Title: web_accessible_resources
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/name
Title: name
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings
Title: browser_specific_settings
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/sidebar_action
Title: sidebar_action
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/homepage_url
Title: homepage_url
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/description
Title: description
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/dictionaries
Title: dictionaries
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/page_action
Title: page_action
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/short_name
Title: short_name
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/devtools_page
Title: devtools_page
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/commands
Title: commands
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/incognito
Title: incognito
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/protocol_handlers
Title: protocol_handlers
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/icons
Title: icons
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/manifest_version
Title: manifest_version
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/author
Title: author
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/version_name
Title: version_name
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/permissions
Title: permissions
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/optional_permissions
Title: optional_permissions
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/developer
Title: developer
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/default_locale
Title: default_locale
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/options_page
Title: options_page
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/content_scripts
Title: content_scripts
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/content_security_policy
Title: content_security_policy
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/omnibox
Title: omnibox
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/offline_enabled
Title: offline_enabled
on GitHub

No new external URLs

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/chrome_url_overrides
Title: chrome_url_overrides
on GitHub

No new external URLs

(this comment was updated 2021-05-31 04:55:08.431153)

@teoli2003 teoli2003 changed the title Put browser-compat info in front-runner for we/manifest.json/* Put browser-compat info in front-runner for web/manifest.json/* May 31, 2021
@teoli2003 teoli2003 mentioned this pull request May 31, 2021
Closed
51 tasks
@teoli2003 teoli2003 changed the title Put browser-compat info in front-runner for web/manifest.json/* Put browser-compat info in front-runner for webextensions/manifest.json/* May 31, 2021
Elchi3
Elchi3 approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Elchi3 Elchi3 merged commit 58d2649 into mdn:main May 31, 2021
@teoli2003 teoli2003 deleted the move-browser-compat-in-front-runner-we-manifest branch May 31, 2021 18:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

@zombie zombie Awaiting requested review from zombie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoli2003 @Elchi3