Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update templates for BCD in front-runner #5544

Merged

Conversation

teoli2003
Copy link
Contributor

What was wrong/why is this fix needed? (quick summary only)

We have updated most of MDN to use BCD in front-runner. It is important that new pages abide by this convention. We have template pages that we invite author to use. We need to update them.

MDN URL of the main page changed

Subpages of https://developer.mozilla.org/en-US/docs/MDN/Structures/Page_types

Issue number (if there is an associated issue)

Part of openwebdocs/project#36

Anything else that could help us review it

@teoli2003 teoli2003 requested a review from a team as a code owner June 1, 2021 14:40
@teoli2003 teoli2003 requested review from Rumyra and removed request for a team June 1, 2021 14:40
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2021

Preview URLs

Flaws

URL: /en-US/docs/MDN/Structures/Page_types/API_event_handler_subpage_template
Title: API event handler subpage template
on GitHub
Flaw count: 2

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheProperty

URL: /en-US/docs/MDN/Structures/Page_types/HTML_element_page_template
Title: HTML element page template
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheElement

URL: /en-US/docs/MDN/Structures/Page_types/API_reference_page_template
Title: API reference page template
on GitHub
Flaw count: 10

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
    • /en-US/docs/Web/API/NameOfTheInterface/NameOfTheInterface does not exist
    • /en-US/docs/Web/API/NameOfTheInterface does not exist
    • /en-US/docs/Web/API/NameOfParentInterface does not exist
    • /en-US/docs/Web/API/NameOfTheInterface/property1 does not exist
    • and 4 more flaws omitted
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheInterface

URL: /en-US/docs/MDN/Structures/Page_types/CSS_property_page_template
Title: CSS property page template
on GitHub
Flaw count: 4

  • macros:
    • /en-US/docs/Web/CSS/subvalue1 does not exist
    • /en-US/docs/Web/CSS/subvalue2 does not exist
    • `/home/runner/work/content/content/node_modules/@mdn/yari/kumascript/macros/CSSSyntax.ejs:1

1| <%
2| /*
3| Displays the syntax of a CSS property or descriptor
4|

No syntax found in DB for 'css_property_page_template'`

  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheProperty

URL: /en-US/docs/MDN/Structures/Page_types/API_method_subpage_template
Title: API method subpage template
on GitHub
Flaw count: 2

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheMethod

URL: /en-US/docs/MDN/Structures/Page_types/CSS_selector_page_template
Title: CSS selector page template
on GitHub
Flaw count: 2

  • macros:
    • `/home/runner/work/content/content/node_modules/@mdn/yari/kumascript/macros/CSSSyntax.ejs:1

1| <%
2| /*
3| Displays the syntax of a CSS property or descriptor
4|

No syntax found in DB for 'css_selector_page_template'`

  • bad_bcd_queries:
    • No BCD data for query: css.selectors.NameOfTheSelector

URL: /en-US/docs/MDN/Structures/Page_types/API_event_subpage_template
Title: API event subpage template
on GitHub
Flaw count: 2

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheEvent_event

URL: /en-US/docs/MDN/Structures/Page_types/API_landing_page_template
Title: API landing page template
on GitHub
Flaw count: 5

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
    • /en-US/docs/Web/API/NameOfTheInterface does not exist
    • /en-US/docs/Web/API/Addition1 does not exist
    • /en-US/docs/Web/API/Addition1 does not exist
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfAPI

URL: /en-US/docs/MDN/Structures/Page_types/SVG_element_page_template
Title: SVG element page template
on GitHub
Flaw count: 2

  • macros:
    • /en-US/docs/Web/API/NameOfSVGDOMElement does not exist
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheElement

URL: /en-US/docs/MDN/Structures/Page_types/API_property_subpage_template
Title: API property subpage template
on GitHub
Flaw count: 2

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheProperty

URL: /en-US/docs/MDN/Structures/Page_types/API_constructor_subpage_template
Title: API constructor subpage template
on GitHub
Flaw count: 3

  • macros:
    • /en-us/docs/web/api/mdn (url: /en-US/docs/Web/API/MDN) does not exist
    • /en-US/docs/Web/API/%3Cem%3EName%3C/em%3EOf%3Cem%3ETheParentInterface%3C/em%3E does not exist
  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheConstructor

URL: /en-US/docs/MDN/Structures/Page_types/HTTP_header_page_template
Title: HTTP header page template
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: path.to.feature.NameOfTheHeader

External URLs

URL: /en-US/docs/MDN/Structures/Page_types/API_event_handler_subpage_template
Title: API event handler subpage template
on GitHub

No new external URLs


URL: /en-US/docs/MDN/Structures/Page_types/HTML_element_page_template
Title: HTML element page template
on GitHub

No new external URLs


URL: /en-US/docs/MDN/Structures/Page_types/API_reference_page_template
Title: API reference page template
on GitHub

No new external URLs


URL: /en-US/docs/MDN/Structures/Page_types/CSS_property_page_template
Title: CSS property page template
on GitHub

No new external URLs


URL: /en-US/docs/MDN/Structures/Page_types/API_method_subpage_template
Title: API method subpage template
on GitHub

No new external URLs


URL: /en-US/docs/MDN/Structures/Page_types/CSS_selector_page_template
Title: CSS selector page template
on GitHub

No new external URLs


URL: /en-US/docs/MDN/Structures/Page_types/API_event_subpage_template
Title: API event subpage template
on GitHub

No new external URLs


URL: /en-US/docs/MDN/Structures/Page_types/API_landing_page_template
Title: API landing page template
on GitHub

No new external URLs


URL: /en-US/docs/MDN/Structures/Page_types/SVG_element_page_template
Title: SVG element page template
on GitHub

No new external URLs


URL: /en-US/docs/MDN/Structures/Page_types/API_property_subpage_template
Title: API property subpage template
on GitHub

No new external URLs


URL: /en-US/docs/MDN/Structures/Page_types/API_constructor_subpage_template
Title: API constructor subpage template
on GitHub

No new external URLs


URL: /en-US/docs/MDN/Structures/Page_types/HTTP_header_page_template
Title: HTTP header page template
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit 4ae1f9d into mdn:main Jun 1, 2021
@teoli2003 teoli2003 deleted the update-templates-for-BCD-in-front-runner branch June 1, 2021 15:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants