Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move BCD in front-runner for webdriver/* #5592

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Move BCD in front-runner for webdriver/* #5592

merged 1 commit into from
Jun 2, 2021

Conversation

teoli2003
Copy link
Contributor

What was wrong/why is this fix needed? (quick summary only)

We want to have browser-compat in front-runner: this allows us to write {{Compat}} without parameter, and in the future, {{Spec}} (and likely more).

This PR covers all of webdriver/* .

MDN URL of the main page changed

11 files in api/*

Issue number (if there is an associated issue)

openwebdocs/project#36

Anything else that could help us review it
Done manually, but all were straightforward.

@teoli2003 teoli2003 requested a review from a team as a code owner June 2, 2021 15:48
@teoli2003 teoli2003 requested review from Rumyra and removed request for a team June 2, 2021 15:48
@teoli2003 teoli2003 mentioned this pull request Jun 2, 2021
Closed
51 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2021

Preview URLs

Flaws

URL: /en-US/docs/Web/WebDriver/Commands
Title: Commands
on GitHub
Flaw count: 45

  • bad_bcd_links:
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • no explanation!
    • and 40 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Commands/SetWindowRect
Title: Set Window Rect
on GitHub
Flaw count: 12

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/UnsupportedOperation
    • Can't resolve /en-US/docs/Web/WebDriver/Capabilities/setWindowRect
    • Can't resolve /en-US/docs/Web/WebDriver/WindowRect
    • Can't resolve /en-US/docs/Web/WebDriver/WebWindow
    • Can't resolve /en-US/docs/Web/WebDriver/WebWindow
    • and 7 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Commands/GetWindowRect
Title: Get Window Rect
on GitHub
Flaw count: 8

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/Clients
    • Can't resolve /en-US/docs/Web/WebDriver/WindowRect
    • Can't resolve /en-US/docs/Web/WebDriver/SetWindowRect
    • Can't resolve /en-US/docs/Web/WebDriver/WebWindow
    • and 3 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Commands/SetTimeouts
Title: Set Timeouts
on GitHub
Flaw count: 5

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/ExecuteScript
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/ExecuteAsyncScript
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/ScriptTimeoutError
    • Link points to the page it's already on

URL: /en-US/docs/Web/WebDriver/Commands/GetTimeouts
Title: Get Timeouts
on GitHub
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/ExecuteScript
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/ExecuteAsyncScript
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/ScriptTimeoutError

URL: /en-US/docs/Web/WebDriver/Commands/GetElementTagName
Title: Get Element Tag Name
on GitHub
Flaw count: 6

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Command
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/SessionNotCreated
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/NoSuchWindow
    • and 1 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Commands/CloseWindow
Title: Close Window
on GitHub
Flaw count: 5

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Command
    • Can't resolve /en-US/docs/Web/WebDriver/WebWindow
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/UnexpectedAlertOpen
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/SwitchToWindow
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/GetWindowHandle

URL: /en-US/docs/Web/WebDriver/Commands/New_Window
Title: New Window
on GitHub
Flaw count: 5

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/WebWindow
    • Can't resolve /en-US/docs/Web/WebDriver/WebWindow
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/NoSuchWindow
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/UnexpectedAlertOpen
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/UnsupportedOperation

URL: /en-US/docs/Web/WebDriver/Commands/GetElementAttribute
Title: Get Element Attribute
on GitHub
Flaw count: 7

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Command
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/SessionNotCreated
    • and 2 more flaws omitted

URL: /en-US/docs/Web/WebDriver/Commands/GetWindowHandles
Title: Get Window Handles
on GitHub
Flaw count: 5

  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/Command
    • Can't resolve /en-US/docs/Web/WebDriver/WebWindow
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/SwitchToWindow
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/SwitchToWindow
    • Can't resolve /en-US/docs/Web/WebDriver/Commands/GetWindowHandle

URL: /en-US/docs/Web/WebDriver/Commands/GetElementProperty
Title: Get Element Property
on GitHub
Flaw count: 7

  • macros:
    • /en-US/docs/Web/API/Element/getProperty does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/WebElement
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/SessionNotCreated
    • Can't resolve /en-US/docs/Web/WebDriver/Errors/NoSuchWindow
    • and 1 more flaws omitted

External URLs

URL: /en-US/docs/Web/WebDriver/Commands
Title: Commands
on GitHub

No new external URLs

URL: /en-US/docs/Web/WebDriver/Commands/SetWindowRect
Title: Set Window Rect
on GitHub

No new external URLs

URL: /en-US/docs/Web/WebDriver/Commands/GetWindowRect
Title: Get Window Rect
on GitHub

No new external URLs

URL: /en-US/docs/Web/WebDriver/Commands/SetTimeouts
Title: Set Timeouts
on GitHub

No new external URLs

URL: /en-US/docs/Web/WebDriver/Commands/GetTimeouts
Title: Get Timeouts
on GitHub

No new external URLs

URL: /en-US/docs/Web/WebDriver/Commands/GetElementTagName
Title: Get Element Tag Name
on GitHub

No new external URLs

URL: /en-US/docs/Web/WebDriver/Commands/CloseWindow
Title: Close Window
on GitHub

No new external URLs

URL: /en-US/docs/Web/WebDriver/Commands/New_Window
Title: New Window
on GitHub

No new external URLs

URL: /en-US/docs/Web/WebDriver/Commands/GetElementAttribute
Title: Get Element Attribute
on GitHub

No new external URLs

URL: /en-US/docs/Web/WebDriver/Commands/GetWindowHandles
Title: Get Window Handles
on GitHub

No new external URLs

URL: /en-US/docs/Web/WebDriver/Commands/GetElementProperty
Title: Get Element Property
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit 5c45456 into mdn:main Jun 2, 2021
@teoli2003 teoli2003 deleted the webdriver-bcd-front-runner branch June 2, 2021 17:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

@Rumyra Rumyra Awaiting requested review from Rumyra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teoli2003 @sideshowbarker