Separation constraint using surface vector projection

doc/options.yaml

@@ -1530,7 +1530,7 @@ sepSensorModel:
     We project the freestream over the desired surface and compute the desired flow direction based on the sweep angle of the wing (``sepSweepAngleCorrection``) in 3D cases (For airfoils, the desired direction would be the projected freestream vector over the airfoil surface).
     Then we compute the deviation between the local flow velocity and this desired direction. We use a separation metric to integrate this computation over the desired surface.
     ``0`` means no separation and ``1`` means that the flow is fully separated. 
-    Although, this method is formulated for 3D cases, it is appropriate for airfoils. However, for 3D cases, please use ``surfvec_ks`` option, which has KS aggregation to aggregate the maximum separation sensor value to be constrained. 
+    Although this method is formulated for 3D cases, it is appropriate for airfoils. However, for 3D cases, please use ``surfvec_ks`` option, which has KS aggregation to aggregate the maximum separation sensor value to be constrained. This option will effectively alleviate separation anywhere on the interested surface and provide separation free design. On the other hand, ``surfvec`` option may  not gurrantee to achieve separation free design when the separation happens in a very smaller region and thus, the integration over this region may not violate the constraint. 
   surfvec_ks: This method uses similar formulation to ``surfvec`` to compute the maximum separation sensor value on a desired surface instead of integrating over this surface.
     Therefore, this maximum separation sensor value from KS aggregation function can be constrained to alleviate separation.
 

src/output/outputMod.F90

@@ -2252,7 +2252,7 @@ subroutine storeSurfsolInBuffer(sps, buffer, nn, blockID, &
                     sensor = (v(1) * vectCorrected(1) + v(2) * vectCorrected(2) + &
                               v(3) * vectCorrected(3))
 
-                    sensor = one / two * (one - sensor)
+                    sensor = half * (one - sensor)
                     buffer(nn) = sensor
                 end do
             end do
@@ -2264,10 +2264,7 @@ subroutine storeSurfsolInBuffer(sps, buffer, nn, blockID, &
                     v(1) = ww2(i, j, ivx)
                     v(2) = ww2(i, j, ivy)
                     v(3) = ww2(i, j, ivz)
-                    ! Get normalized surface velocity:
-                    ! v(1) = ww2(ii, jj, ivx)
-                    ! v(2) = ww2(ii, jj, ivy)
-                    ! v(3) = ww2(ii, jj, ivz)
+
                     ! Normalize
                     v = v / (sqrt(v(1)**2 + v(2)**2 + v(3)**2) + 1e-16)
 

src/solver/surfaceIntegrations.F90

@@ -1475,7 +1475,7 @@ subroutine computeSepSenMaxFamily(famList)
 
         ! loop over the TS instances and compute sepsenmax_family for each TS instance
         do sps = 1, nTimeIntervalsSpectral
-            ! set the local cp min to a large value so that we get the actual min
+            ! set the local sepsensor to a smaller value so that we get the actual max
             sepsensor_local = 0.0_realType
             do nn = 1, nDom
                 call setPointers(nn, 1, sps)
@@ -1550,9 +1550,6 @@ subroutine computeSepSenMaxFamily(famList)
 
                                 sensor = half * (one - sensor) * blk
 
-                                ! only take this if its a compute cell
-                                ! if (BCData(mm)%iblank(i, j) .eq. one) then
-
                                 ! compare it against the current value on this proc
                                 sepsensor_local = max(sepsensor_local, sensor)
                                 ! end if

tests/reg_tests/test_separation.py

@@ -23,21 +23,7 @@
         "aero_prob": ap_naca0012_separation,
         "N_PROCS": 2,
         "options": {
-            "gridfile": gridFile,
-            "outputdirectory": os.path.join(baseDir, "../output_files"),
-            "writevolumesolution": False,
-            "writesurfacesolution": False,
-            "writetecplotsurfacesolution": False,
-            "mgcycle": "sg",
-            "ncycles": 1000,
-            "useanksolver": True,
-            "usenksolver": True,
-            "anksecondordswitchtol": 1e-2,
-            "nkswitchtol": 1e-6,
-            "volumevariables": ["temp", "mach", "resrho", "cp"],
-            "equationType": "RANS",
-            "l2convergence": 1e-15,
-            "adjointl2convergence": 1e-15,
+
             "sepSensorModel": "surfvec_ks",
             "sepSensorMaxRho": 100.0,
             "sepSweepAngleCorrection": 0.0,
@@ -49,21 +35,7 @@
         "aero_prob": ap_naca0012_separation,
         "N_PROCS": 2,
         "options": {
-            "gridfile": gridFile,
-            "outputdirectory": os.path.join(baseDir, "../output_files"),
-            "writevolumesolution": False,
-            "writesurfacesolution": False,
-            "writetecplotsurfacesolution": False,
-            "mgcycle": "sg",
-            "ncycles": 1000,
-            "useanksolver": True,
-            "usenksolver": True,
-            "anksecondordswitchtol": 1e-2,
-            "nkswitchtol": 1e-6,
-            "volumevariables": ["temp", "mach", "resrho", "cp"],
-            "equationType": "RANS",
-            "l2convergence": 1e-15,
-            "adjointl2convergence": 1e-15,
+
             "sepSensorModel": "surfvec",
             "sepSweepAngleCorrection": 0.0,
         },
@@ -74,21 +46,7 @@
         "aero_prob": ap_naca0012_separation,
         "N_PROCS": 2,
         "options": {
-            "gridfile": gridFile,
-            "outputdirectory": os.path.join(baseDir, "../output_files"),
-            "writevolumesolution": False,
-            "writesurfacesolution": False,
-            "writetecplotsurfacesolution": False,
-            "mgcycle": "sg",
-            "ncycles": 1000,
-            "useanksolver": True,
-            "usenksolver": True,
-            "anksecondordswitchtol": 1e-2,
-            "nkswitchtol": 1e-6,
-            "volumevariables": ["temp", "mach", "resrho", "cp"],
-            "equationType": "RANS",
-            "l2convergence": 1e-15,
-            "adjointl2convergence": 1e-15,
+
             "sepSensorModel": "heaviside",
             "sepSweepAngleCorrection": 0.0,
         },
@@ -115,6 +73,21 @@ def setUp(self):
         super().setUp()
 
         options = copy.copy(adflowDefOpts)
+        options.update({"gridfile": gridFile,
+            "outputdirectory": os.path.join(baseDir, "../output_files"),
+            "writevolumesolution": False,
+            "writesurfacesolution": False,
+            "writetecplotsurfacesolution": False,
+            "mgcycle": "sg",
+            "ncycles": 1000,
+            "useanksolver": True,
+            "usenksolver": True,
+            "anksecondordswitchtol": 1e-2,
+            "nkswitchtol": 1e-6,
+            "volumevariables": ["temp", "mach", "resrho", "cp"],
+            "equationType": "RANS",
+            "l2convergence": 1e-15,
+            "adjointl2convergence": 1e-15,})
         options.update(self.options)
 
         # Setup aeroproblem
@@ -133,7 +106,7 @@ def setUp(self):
         self.CFDSolver.addFunction("sepsensor", "wingup")
 
     def test_separation_metrics_and_derivatives(self):
-        evalFuncs = ["sepsensor_wingup", "cl"]
+        evalFuncs = ["sepsensor_wingup"]
 
         self.CFDSolver(self.ap)
 
@@ -236,6 +209,21 @@ def setUp(self):
         super().setUp()
 
         options = copy.copy(adflowDefOpts)
+        options.update({"gridfile": gridFile,
+            "outputdirectory": os.path.join(baseDir, "../output_files"),
+            "writevolumesolution": False,
+            "writesurfacesolution": False,
+            "writetecplotsurfacesolution": False,
+            "mgcycle": "sg",
+            "ncycles": 1000,
+            "useanksolver": True,
+            "usenksolver": True,
+            "anksecondordswitchtol": 1e-2,
+            "nkswitchtol": 1e-6,
+            "volumevariables": ["temp", "mach", "resrho", "cp"],
+            "equationType": "RANS",
+            "l2convergence": 1e-15,
+            "adjointl2convergence": 1e-15,})
         options.update(self.options)
 
         # Setup aeroproblem
@@ -270,7 +258,7 @@ def cmplx_test_separation_adjoints(self):
         self.assert_solution_failure()
         self.CFDSolver.evalFunctions(self.ap, funcs)
 
-        evalFuncs = ["sepsensor_wingup", "cl"]
+        evalFuncs = ["sepsensor_wingup"]
         funcs_plus = {}
         for dv in ["alpha", "vol_perturbation"]:
             if dv == "alpha":