added brave browser #111
added brave browser #111
Conversation
|
"added brave browser":
"fixed broken title in set-profile":
"nondefault profile bookmark-search fix":
|
| profileSlice, err := s.ProfileService.GetProfiles(browser) | ||
|
|
||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| profileName := profiles.DefaultProfileName | ||
|
|
||
| if browser.ProfileName == "" { | ||
| if profile, err := profileSlice.FirstActive(); err == nil && profile.Name != "" { | ||
| profileName = profile.Name | ||
| } | ||
| } | ||
|
|
||
| browser.ProfileName = profileName | ||
|
|
There was a problem hiding this comment.
Could you please explain why you have remove that block?
There was a problem hiding this comment.
You just need to set profile via -profiles command.
There was a problem hiding this comment.
This is the current problem:
First I made sure that the default browser is selected:
Then I searched for a bookmark and the results were from the Default browser:
But when i switched to Profile 1 an made sure that it was activated
It also saved the change to the browser.yml file:
But after that when I searched for a bookmark and the results were still from the Default browser
There was a problem hiding this comment.
And removing that code resolved this problem
|
I hope the GUIDs are now to your liking. |
|
@mdreizin can you review this please? :) |
|
Is anyone looking into reviewing the PR? |
No description provided.