Add some improved internal types

docs/_asset/editor.jsx

@@ -536,11 +536,13 @@ function Playground() {
  * @returns {JSX.Element}
  */
 function ErrorFallback(props) {
-  console.log('fb:', arguments)
+  /** @type {Error} */
+  // type-coverage:ignore-next-line
+  const error = props.error
   return (
     <div role="alert">
       <p>Something went wrong:</p>
-      <DisplayError error={props.error} />
+      <DisplayError error={error} />
       <button type="button" onClick={props.resetErrorBoundary}>
         Try again
       </button>

docs/_component/blog.jsx

@@ -45,6 +45,7 @@ export function BlogEntry(props) {
         : [meta.readingTime, meta.readingTime]
       : []
   ).map((d) => Math.ceil(d))
+  /** @type {string | undefined} */
   let timeLabel
 
   if (time.length > 1 && time[0] !== time[1]) {

docs/_component/layout.jsx

@@ -51,6 +51,7 @@ export function Layout(props) {
         : [meta.readingTime, meta.readingTime]
       : []
   ).map((d) => (d > 15 ? Math.round(d / 5) * 5 : Math.ceil(d)))
+  /** @type {string | undefined} */
   let timeLabel
 
   if (metaTime.length > 1 && metaTime[0] !== metaTime[1]) {

docs/_component/nav.jsx

@@ -3,6 +3,7 @@
 
 /**
  * @typedef {import('hast').ElementContent} ElementContent
+ * @typedef {import('react').ReactNode} ReactNode
  * @typedef {import('./sort.js').Item} Item
  */
 
@@ -59,7 +60,9 @@ export function NavItem(props) {
   const defaultTitle = apStyleTitleCase(
     name.replace(/\/$/, '').split('/').pop()
   )
+  /** @type {ReactNode} */
   let description
+  /** @type {string | undefined} */
   let published
 
   if (includeDescription) {

docs/_component/sort.js

@@ -35,20 +35,24 @@ export function sortItems(items, sortString = 'navSortSelf,meta.title') {
 
     while (++index < fields.length) {
       const [field, order] = fields[index]
+      /** @type {unknown} */
       let a = dlv(left.data, field)
+      /** @type {unknown} */
       let b = dlv(right.data, field)
 
       if (a && typeof a === 'object' && 'valueOf' in a) a = a.valueOf()
       if (b && typeof b === 'object' && 'valueOf' in b) b = b.valueOf()
 
       const score =
-        typeof a === 'number' || typeof b === 'number'
-          ? a === null || a === undefined
-            ? 1
-            : b === null || b === undefined
-            ? -1
-            : a - b
-          : collator(a, b)
+        typeof a === 'string' && typeof b === 'string'
+          ? collator(a, b)
+          : typeof a === 'number' && typeof b === 'number'
+          ? a - b
+          : a === null || a === undefined
+          ? 1
+          : b === null || b === undefined
+          ? -1
+          : 0
       const result = order === 'asc' ? score : -score
       if (result) return result
     }

package.json

@@ -170,6 +170,11 @@
     "atLeast": 100,
     "detail": true,
     "ignoreCatch": true,
+    "#": "needed `any`s",
+    "ignoreFiles": [
+      "packages/mdx/lib/util/resolve-evaluate-options.d.ts",
+      "packages/mdx/lib/util/resolve-evaluate-options.js"
+    ],
     "strict": true
   },
   "xo": {

packages/esbuild/package.json

@@ -52,12 +52,6 @@
     "test-api": "node --conditions development test/index.js",
     "test-coverage": "c8 --100 --reporter lcov npm run test-api"
   },
-  "typeCoverage": {
-    "atLeast": 100,
-    "detail": true,
-    "ignoreCatch": true,
-    "strict": true
-  },
   "xo": {
     "prettier": true,
     "rules": {

packages/loader/package.json

@@ -56,12 +56,6 @@
     "test-api": "node --conditions development test/index.js",
     "test-coverage": "c8 --100 --reporter lcov npm run test-api"
   },
-  "typeCoverage": {
-    "atLeast": 100,
-    "detail": true,
-    "ignoreCatch": true,
-    "strict": true
-  },
   "xo": {
     "prettier": true,
     "rules": {

packages/mdx/package.json

@@ -72,12 +72,6 @@
     "test-api": "node --conditions development test/index.js",
     "test-coverage": "c8 --100 --reporter lcov npm run test-api"
   },
-  "typeCoverage": {
-    "atLeast": 100,
-    "detail": true,
-    "ignoreCatch": true,
-    "strict": true
-  },
   "xo": {
     "prettier": true,
     "rules": {

packages/node-loader/package.json

@@ -46,12 +46,6 @@
     "test-api": "node --conditions development --loader=./test/react-18-node-loader.js test/index.js",
     "test-coverage": "c8 --100 --reporter lcov npm run test-api"
   },
-  "typeCoverage": {
-    "atLeast": 100,
-    "detail": true,
-    "ignoreCatch": true,
-    "strict": true
-  },
   "xo": {
     "prettier": true,
     "rules": {

packages/preact/package.json

@@ -52,12 +52,6 @@
     "test-api": "node --conditions development --loader=../../script/jsx-loader.js test/test.jsx",
     "test-coverage": "c8 --100 --reporter lcov npm run test-api"
   },
-  "typeCoverage": {
-    "atLeast": 100,
-    "detail": true,
-    "ignoreCatch": true,
-    "strict": true
-  },
   "xo": {
     "overrides": [
       {

packages/react/package.json

@@ -52,12 +52,6 @@
     "test-api": "node --conditions development --loader=../../script/jsx-loader.js test/test.jsx",
     "test-coverage": "c8 --100 --reporter lcov npm run test-api"
   },
-  "typeCoverage": {
-    "atLeast": 100,
-    "detail": true,
-    "ignoreCatch": true,
-    "strict": true
-  },
   "xo": {
     "overrides": [
       {

packages/register/lib/index.cjs

@@ -49,7 +49,11 @@ function register(options) {
    */
   function mdx(module, path) {
     const file = processSync(fs.readFileSync(path))
+    // To do: type `run`.
+    /** @type {{default: unknown}} */
     const result = runSync(file, runtime)
+    // Something going weird here w/ `type-coverage`.
+    // type-coverage:ignore-next-line
     module.exports = result.default
     module.loaded = true
   }
@@ -82,9 +86,15 @@ function load(filePath, callback) {
     )
   }
 
-  import(filePath).then((module) => {
-    done(null, module)
-  }, done)
+  import(filePath).then(
+    /**
+     * @param {unknown} module
+     */
+    function (module) {
+      done(null, module)
+    },
+    done
+  )
 
   /**
    *

packages/register/package.json

@@ -49,12 +49,6 @@
     "test-api": "node --conditions development --require ./index.cjs test/index.cjs",
     "test-coverage": "c8 --100 --reporter lcov npm run test-api"
   },
-  "typeCoverage": {
-    "atLeast": 100,
-    "detail": true,
-    "ignoreCatch": true,
-    "strict": true
-  },
   "xo": {
     "prettier": true,
     "rules": {

packages/remark-mdx/package.json

@@ -49,12 +49,6 @@
     "test-api": "node --conditions development test/index.js",
     "test-coverage": "c8 --100 --reporter lcov npm run test-api"
   },
-  "typeCoverage": {
-    "atLeast": 100,
-    "detail": true,
-    "ignoreCatch": true,
-    "strict": true
-  },
   "xo": {
     "prettier": true,
     "rules": {

packages/rollup/package.json

@@ -52,12 +52,6 @@
     "test-api": "node --conditions development test/index.js",
     "test-coverage": "c8 --100 --reporter lcov npm run test-api"
   },
-  "typeCoverage": {
-    "atLeast": 100,
-    "detail": true,
-    "ignoreCatch": true,
-    "strict": true
-  },
   "xo": {
     "prettier": true,
     "rules": {

packages/vue/package.json

@@ -48,19 +48,12 @@
     "test-api": "node --conditions development test/index.js",
     "test-coverage": "c8 --100 --reporter lcov npm run test-api"
   },
-  "typeCoverage": {
-    "atLeast": 100,
-    "detail": true,
-    "strict": true,
-    "ignoreCatch": true
-  },
   "xo": {
     "prettier": true,
     "rules": {
       "n/file-extension-in-import": "off",
       "unicorn/prefer-node-protocol": "off",
       "unicorn/prefer-string-replace-all": "off"
     }
-  },
-  "gitHead": "bf7deab69996449cb99c2217dff75e65855eb2c1"
+  }
 }