refactor: flush containsActiveZone when child zones removed

measuredco · Dec 27, 2024 · 681d61c · 681d61c
1 parent 4eb39ff
commit 681d61c
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 0 deletions.
diff --git a/packages/core/components/DraggableComponent/index.tsx b/packages/core/components/DraggableComponent/index.tsx
@@ -145,6 +145,24 @@ export const DraggableComponent = ({
     [setLocalZones]
   );
 
+  const unregisterLocalZone = useCallback(
+    (zoneCompound: string) => {
+      // Propagate local zone
+      ctx?.unregisterLocalZone?.(zoneCompound);
+
+      setLocalZones((obj) => {
+        const newLocalZones = {
+          ...obj,
+        };
+
+        delete newLocalZones[zoneCompound];
+
+        return newLocalZones;
+      });
+    },
+    [setLocalZones]
+  );
+
   const containsActiveZone =
     Object.values(localZones).filter(Boolean).length > 0;
 
@@ -490,6 +508,7 @@ export const DraggableComponent = ({
         index,
         depth: depth + 1,
         registerLocalZone,
+        unregisterLocalZone,
         path: [...path, id],
       }}
     >

diff --git a/packages/core/components/DropZone/context.tsx b/packages/core/components/DropZone/context.tsx
@@ -30,6 +30,7 @@ export type DropZoneContext<UserConfig extends Config = Config> = {
   mode?: "edit" | "render";
   depth: number;
   registerLocalZone?: (zone: string, active: boolean) => void; // A zone as it pertains to the current area
+  unregisterLocalZone?: (zone: string) => void;
   deepestZone?: string | null;
   deepestArea?: string | null;
   nextDeepestZone?: string | null;

diff --git a/packages/core/components/DropZone/index.tsx b/packages/core/components/DropZone/index.tsx
@@ -65,6 +65,7 @@ function DropZoneEdit({
     registerZoneArea,
     depth,
     registerLocalZone,
+    unregisterLocalZone,
     deepestZone = rootDroppableId,
     deepestArea,
     nextDeepestArea,
@@ -93,6 +94,10 @@ function DropZoneEdit({
     }
 
     return () => {
+      if (unregisterLocalZone) {
+        unregisterLocalZone(zoneCompound);
+      }
+
       if (ctx?.unregisterZone) {
         ctx?.unregisterZone(zoneCompound);
       }