MBS-8967: Add modal to show errors when trying to change sth #46
Conversation
|
Failing GHA is not related to this PR |
There was a problem hiding this comment.
This fixes part of the issue when trying to do for example things you aren't allowed to.
However, the error handling should be implemented for every webservices call, also for the permanent update polls for example. Currently, if for testing purposes I insert an exception into get_kanban_content_update the app will just crash.
The error handling should properly handle the issue of connection loss.
Maybe it's also possible/easier to use displayException function?
|
Added an alert for displaying connection loss. |
| * @param {*} ex | ||
| */ | ||
| processFail(ex) { | ||
| Notification.alert(getString('error'), ex.message, getString('cancel')); |
There was a problem hiding this comment.
alert is an async function, it needs to be called with await
| @@ -217,9 +232,31 @@ export default class { | |||
| boardid: state.board.id, | |||
| timestamp: state.common.timestamp, | |||
| }, | |||
| fail: () => { | |||
| */ | ||
| resetUpdateFails() { | ||
| this.updateFails = 0; | ||
| document.querySelector('.mod_kanban_update_error').classList.add('hidden'); |
There was a problem hiding this comment.
you probably want to add this to the selectors.js and use the constant defined there?
Also AFAIK CSS classes should only be used for styling. For "queryselectoring" an element a data attribute should be used.
| processUpdateFail() { | ||
| this.updateFails++; | ||
| if (this.updateFails > 2) { | ||
| document.querySelector('.mod_kanban_update_error').classList.remove('hidden'); |
There was a problem hiding this comment.
also use the selectors constant
| @@ -247,6 +284,9 @@ export default class { | |||
| cardid: cardId, | |||
| timestamp: timestamp, | |||
| }, | |||
| fail: () => { | |||
| @@ -276,6 +316,9 @@ export default class { | |||
| cardid: cardId, | |||
| timestamp: timestamp, | |||
| }, | |||
| fail: () => { | |||
PhMemmel
force-pushed
the
MBS-8967-error-handling
branch
from
b44e867
to
5791dad
Compare
Implements #14