V2.3.3 fix error in Firefox (#622)

mebjas · Nov 23, 2022 · 9c5c54c · 9c5c54c
1 parent 9b253ff
commit 9c5c54c
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/changelog.md b/changelog.md
@@ -1,3 +1,6 @@
+### Version 2.3.3
+Quick fix for - [issue#621](https://github.com/mebjas/html5-qrcode/issues/621). With this zoom & torch is not supported in firefox for now.
+
 ### Version 2.3.2
 
 #### Features or bug fixes.

diff --git a/minified/html5-qrcode.min.js b/minified/html5-qrcode.min.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "html5-qrcode",
-  "version": "2.3.2",
+  "version": "2.3.3",
   "description": "A cross platform HTML5 QR Code & bar code scanner",
   "main": "./cjs/index.js",
   "module": "./esm/index.js",

diff --git a/src/camera/core-impl.ts b/src/camera/core-impl.ts
@@ -34,6 +34,12 @@ abstract class AbstractCameraCapability<T> implements CameraCapability<T> {
     }
 
     public isSupported(): boolean {
+        // TODO(minhazav): Figure out fallback for getCapabilities()
+        // in firefox.
+        // https://developer.mozilla.org/en-US/docs/Web/API/Media_Capture_and_Streams_API/Constraints
+        if (!this.track.getCapabilities) {
+            return false;
+        }
         return this.name in this.track.getCapabilities();
     }