Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements to HorizontalBarChartView #8

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

boherna
Copy link

@boherna boherna commented Jan 20, 2021

Improvements (based on my own needs):

  • Supports custom text to show next to the bars (in my case I needed a different text than the default provided).
  • Adjusts the height and size of the bars and circles, respectively, when the size of the dynamic font changes.
  • Allows setting the max value for calculating the bar width (in my case I needed charts with different dataPoints to have a normalised width regardless of the max values of those dataPoints).

I also changed RoundedRectangle by Capsule to guarantee the rounded edges no matter the height of the bar.

Thanks for sharing SwiftUICharts!

…etric for bar height and circle size. Replaces RoundedRectangle by Capsule. Removes Spacer.
…rge-upstream

# Conflicts:
#	Sources/SwiftUICharts/HorizontalBarChartView.swift
#	Sources/SwiftUICharts/Model/DataPoint.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant