Placate mypy (redux) #197
Draft
Placate mypy (redux) #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsiehupp
force-pushed
the
placate-mypy-redux
branch
3 times, most recently
from
7b75382
to
1cc3eb9
Compare
Signed-off-by: Elsie Hupp <[email protected]>
elsiehupp
force-pushed
the
placate-mypy-redux
branch
from
1cc3eb9
to
310ad8f
Compare
|
It seems the reason the tests are failing is that I did a bunch of things that are valid in Python 3.10 and Python 3.11 but not valid in earlier versions. So basically I need to change my development environment to use Python 3.8, so that I can see all these issues locally. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft version of #186 so that I can run the tests. I'll mark it as ready once the tests pass.