Skip to content

Commit

Permalink
Bump target SDK version to 28 (#87)
Browse files Browse the repository at this point in the history
* Bump target SDK version to 28
* Failed to install the following Android SDK packages as some licences have not been accepted
* Bump testImplementation version of roboelectric

#86
  • Loading branch information
kennsippell authored and newtewt committed Jul 24, 2019
1 parent c2da27a commit 2608929
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ android:
- platform-tools
- extra-android-m2repository
- build-tools-28.0.2
- android-26
- android-28
env:
- GRADLE_OPTS="-XX:MaxPermSize=2048M"
stages:
Expand Down
6 changes: 3 additions & 3 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ dependencies {
implementation 'com.github.Mariovc:ImagePicker:1.2.2'
testImplementation 'junit:junit:4.12'
testImplementation 'com.google.android:android-test:4.1.1.4'
testImplementation 'org.robolectric:robolectric:3.8'
testImplementation 'org.robolectric:robolectric:4.3'
}

def simprintsApiKey, simprintsModuleId, simprintsUserId
Expand Down Expand Up @@ -70,7 +70,7 @@ def getVersionName = {
}

android {
compileSdkVersion 26
compileSdkVersion 28
buildToolsVersion '28.0.2'
packagingOptions {
exclude 'META-INF/LICENSE'
Expand All @@ -82,7 +82,7 @@ android {
versionName getVersionName()
archivesBaseName = "${project.name}-${versionName}"
minSdkVersion 19
targetSdkVersion 26
targetSdkVersion 28
// When upgrading targetSdkVersion, check that the app menu still works on newer devices.
}

Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/medicmobile/webapp/mobile/UtilsTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import static org.junit.Assert.*;

@RunWith(RobolectricTestRunner.class)
@Config(sdk=26)
@Config(sdk=28)
public class UtilsTest {
@Test
public void isUrlRelated_goodNormalUrls() {
Expand Down

0 comments on commit 2608929

Please sign in to comment.