Support for cht-core v3.12 and the cht-script-api #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennsippell
commented
Dec 18, 2021
kennsippell
changed the title
kennsippell
commented
Dec 18, 2021
jkuester
approved these changes
Dec 21, 2021
There was a problem hiding this comment.
👍 I am still getting familiar with all the facets of this harness, so cannot speak much to the completeness of this change set (though I trust @kennsippell's discretion here 😄). I can say that these changes are consistent and do work for me. The test coverage is nice as well (though I agree it would be nice to have some tests for the user role functionality for targets)!
kennsippell
added a commit
that referenced
this pull request
Jan 4, 2022
* Adds support for cht-core v3.13 * Makes 3.13 Enketo wireup the "default" which adds parse-timestamp-to-date * Fixes a regression to the npm run explore command from the test refactoring in Support for cht-core v3.12 and the cht-script-api #151
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a spin-off of the branch adding-cht-script-api-mock written by @latin-panda. Thanks for the great start and getting this code into
shared-libsso this is pretty easy.harness.userRolesand associated handles in the "defaults file" for setting the current user's assigned role. I think we might want to improve this later Improved functionality for setting userRoles #152, and if reviewer has any immediate suggestions please indicate.Refactoring:
#148
cc @eljhkrr