Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#6289): Bumps CouchDb version to 3.3.2 #8107

Merged
merged 93 commits into from
Sep 12, 2023
Merged

feat(#6289): Bumps CouchDb version to 3.3.2 #8107

merged 93 commits into from
Sep 12, 2023

Conversation

dianabarsan
Copy link
Member

@dianabarsan dianabarsan commented Feb 27, 2023

Description

User roles are added to db security on settings change.
Config remains unchanged with a couple of exceptions:

  • request_timeout no longer infinity because of this error
  • added [attachments] section back, as cht-conf depends on those settings to exist and it isn't part of default config anymore

#6289

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@dianabarsan dianabarsan changed the title Bumps CouchDb version to 3.2.1 feat(#7964): Bumps CouchDb version to 3.2.1 Apr 17, 2023
# Conflicts:
#	couchdb/docker-entrypoint.sh
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
# Conflicts:
#	api/src/db.js
#	api/src/migrations/add-national_admin-role.js
#	api/src/services/config-watcher.js
#	api/tests/mocha/services/config-watcher.spec.js
#	couchdb/10-docker-default.ini
#	package.json
#	tests/integration/cht-conf/cht-conf-actions.spec.js
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
# Conflicts:
#	admin/src/js/services/session.js
#	shared-libs/cht-script-api/src/auth.js
#	webapp/src/ts/services/session.service.ts
@dianabarsan
Copy link
Member Author

@garethbowen are we ready for this?
I had to include a commit that stabilizes an e2e test (same code in this PR: #8536) which was failing consistently on this branch.

Signed-off-by: Diana Barsan <[email protected]>
Signed-off-by: Diana Barsan <[email protected]>
Copy link
Member

@garethbowen garethbowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits inline...

Signed-off-by: Diana Barsan <[email protected]>
@garethbowen
Copy link
Member

@dianabarsan I can't think of any reason to hold off and nothing else to test. Let's push the button and get 4.4 out.

The main concern is going to be upgrading multi-node instances, right? We don't have a good solution for that right now, but we're not likely to have one next week either so I feel like it's better to get this done now before more installations are running multi-node solutions.

@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dianabarsan
Copy link
Member Author

I think my main concern is not hitting the right config for us - which is the biggest unknown here. I'm merging.

@dianabarsan dianabarsan merged commit 1251fd0 into master Sep 12, 2023
34 checks passed
@dianabarsan dianabarsan deleted the 7964-couch3 branch September 12, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants