Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make Muffet ignore 403 HTTP Status Codes #1598

Merged
merged 14 commits into from
Oct 8, 2024
Merged

Conversation

andrablaj
Copy link
Member

@andrablaj andrablaj commented Oct 7, 2024

Description

Make Muffet (the link checker) ignore 403 HTTP Status Codes, as tools like Cloudflare usually trigger them.

Removed link to nonexistent GitHub project.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@andrablaj andrablaj self-assigned this Oct 7, 2024
@andrablaj andrablaj changed the title [DO NOT MERGE] chore: Upgrade Muffet chore: Make Muffet ignore 403 HTTP Status Codes Oct 7, 2024
@andrablaj
Copy link
Member Author

@mrjones-plip @esthermmoturi I noticed that the main reason for which the link checker fails is 403 statuses (most probably triggered by tools like Cloudflare). I suggest we add 403 to the list of accepted codes. This will avoid adding more exclude links to muffet.sh.

Additionally, as most of the excluded links are due to 403s, I suggest we remove them from the muffet.sh file.

Copy link
Contributor

@mrjones-plip mrjones-plip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure - let's give it a try!

@andrablaj
Copy link
Member Author

@mrjones-plip @esthermmoturi:

  • I removed the links that were returning 403s from the exclude list in muffet.sh
  • I upgraded muffet to the latest version so we can use the accepted-status-codes functionality.

Any concerns with this approach?

@mrjones-plip
Copy link
Contributor

@andrablaj - no concerns - still looks good!

Let's check the results of the run on ~Monday to ensure it's working as expected (false negatives being the main concern).

@andrablaj andrablaj merged commit eb9807e into main Oct 8, 2024
2 checks passed
@andrablaj andrablaj deleted the upgrade-muffet branch October 8, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants