-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(na): fix up eks install steps per feedback #1611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the changes are great, my two comments are additional requests. I'm fine with creating different issues to follow up on those.
@@ -216,7 +216,7 @@ And then follow these steps: | |||
|
|||
```shell | |||
kubectl config use-context arn:aws:eks:eu-west-2:720541322708:cluster/prod-cht-eks | |||
./troubleshooting/get-volume-binding <DEPLOYMENT> <COUCH-DB-NAME> | jq '.subPath'` | |||
./troubleshooting/get-volume-binding <DEPLOYMENT> <COUCH-DB-NAME> | jq '.subPath' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I first went through this tutorial, I was confused about where I needed to be at this point. I had only read the cloning section from the document, which didn't mention that I needed to be in a specific folder to run certain commands. We only mention cht-deploy in passing earlier saying that we need it to deploy.
So I think it would be helpful to mention here that troubleshooting
are commands from the cht-deploy script location.
* `preExistingEBSVolumeID-1` - set this to be the ID from step 2. For example `vol-f9dsa0f9sad09f0dsa` | ||
* `preExistingEBSVolumeSize` - use the same size as the volume you just cloned | ||
* `dataPathOnDiskForCouchDB` - use the subPath you got in the step above. For example `storage/medic-core/couchdb/data` | ||
|
||
7. Deploy this to development per the [steps above](#starting-and-stopping-aka-deleting). NB - **Be sure to call `kubectl config use-context arn:aws:eks:eu-west-2:720541322708:cluster/dev-cht-eks` before you call** `./cht-deploy`! Always create test instances on the dev cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also include a section about how to delete the volume and snapshot? I feel like cleanup is important, and tracing dangling snapshots will be really difficult in the future.
Great feedback - thanks @dianabarsan ! I've fixed them in 92b2bee . We can use an additional issue to fix anything I got really wrong 😅 |
Description
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.