Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(#79): enhance dbt model testing #151

Merged
merged 15 commits into from
Aug 29, 2024
Merged

chore(#79): enhance dbt model testing #151

merged 15 commits into from
Aug 29, 2024

Conversation

lorerod
Copy link
Contributor

@lorerod lorerod commented Aug 21, 2024

Description

closes #79

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@lorerod lorerod self-assigned this Aug 28, 2024
@lorerod lorerod marked this pull request as ready for review August 28, 2024 00:44
@lorerod lorerod force-pushed the 79-enhance-model-tests branch from 375994d to 2c8629a Compare August 28, 2024 00:45
@njuguna-n
Copy link
Contributor

Hi @lorerod I will finish reviewing this tomorrow (Thursday).

Copy link
Contributor

@njuguna-n njuguna-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on this!

Copy link
Member

@dianabarsan dianabarsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just soooo much better than adding the things inline in the test yml!

@lorerod lorerod merged commit 8442dbd into main Aug 29, 2024
4 checks passed
@lorerod lorerod deleted the 79-enhance-model-tests branch August 29, 2024 14:32
@medic-ci
Copy link

medic-ci commented Sep 2, 2024

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance DBT models testing
4 participants