Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fail builds if dbt run fails #164

Merged
merged 3 commits into from
Sep 17, 2024
Merged

fix: fail builds if dbt run fails #164

merged 3 commits into from
Sep 17, 2024

Conversation

njuguna-n
Copy link
Contributor

Description

Fail the build if dbt run fails

closes #147

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

@njuguna-n njuguna-n requested a review from lorerod September 16, 2024 08:41
@njuguna-n njuguna-n changed the title 147 fail builds if models fail fix: fail builds if dbt run fails Sep 16, 2024
lorerod
lorerod reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@lorerod lorerod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed when we have models without tests?

@njuguna-n
Copy link
Contributor Author

Yes, if you have a syntax error or a misnamed or missing column in a model then this will catch it and fail.

lorerod
lorerod approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@lorerod lorerod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@njuguna-n njuguna-n merged commit 7babb39 into main Sep 17, 2024
4 of 5 checks passed
@njuguna-n njuguna-n deleted the 147-fail-builds-if-models-fail branch September 17, 2024 13:28
@medic-ci
Copy link

🎉 This PR is included in version 1.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorerod lorerod lorerod approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build should fail if models are not all building properly
4 participants
@njuguna-n @medic-ci @lorerod @njogz