Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Node Cluster support for move-node #22

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

henokgetachew
Copy link

@henokgetachew henokgetachew commented Oct 8, 2024

This is an attempt at adding a multi-node support for move-nodes command.

  1. First retrieve the shard mapping from the original instance:
    shard_mapping=$(./get-shard-mapping.js)
  2. Then run (Against the target node):
    move-node.js oldNode1:newNode1 $shard_mapping
    move-node.js oldNode2:newNode2 $shard_mapping
    move-node.js oldNode3:newNode3 $shard_mapping

The above commands can all be run via docker compose in line with the other commands in this repo.

Copy link
Member

@dianabarsan dianabarsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.
I think move-node should only move one node at a time, not more.
Also, we need to add a really strong e2e tests, even one that covers mixed shards (with all nodes having one shard for one db).

bin/move-node.js Outdated Show resolved Hide resolved
@henokgetachew
Copy link
Author

henokgetachew commented Oct 14, 2024

@dianabarsan can you have another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants