Build manager binary in a modular way #156
Conversation
Allow overriding CGO_ENABLED value, debug flags as part of ldflags, and exporting GOEXPERIMENT
razo7
force-pushed
the
modular-manager-binary
branch
from
46cbf89
to
ef6b4d0
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
The suggested changes should not affect nor interfere with how the newly created binary without seeing new Golang flags for the build. |
|
/retest |
5 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: razo7, slintes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow/4.17-openshift-e2e |
|
@slintes: Overrode contexts on behalf of slintes: ci/prow/4.17-openshift-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-0.4 |
|
@razo7: new pull request created: #160 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Why we need this PR
Allow default values for building Golang manager binary using build.sh, and support for other flags.
Changes made
Relates to ECOPROJECT-1972
Test plan
Similar to medik8s/node-maintenance-operator#135