Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Security Scan Job Skippable #11

Closed
wants to merge 1 commit into from
Closed

Conversation

EmteZogaf
Copy link
Collaborator

Add ability to skip the security scan workflow job by adding '[skip security-scan]' flag to head commit message.

@EmteZogaf EmteZogaf changed the title Make Security Scan Job Skippable [WIP] Make Security Scan Job Skippable Jul 12, 2022
@EmteZogaf EmteZogaf force-pushed the skip-security-scan branch from 13f322b to 368fe81 Compare July 12, 2022 15:02
Add ability to skip the security scan workflow job by adding '[skip
security-scan]' flag to head commit message.
@EmteZogaf EmteZogaf force-pushed the skip-security-scan branch from 368fe81 to 8bd3cf5 Compare July 12, 2022 15:14
@EmteZogaf
Copy link
Collaborator Author

EmteZogaf commented Jul 12, 2022

Skipping works. See github action runs for tags v1.0.6-BETA (fails without skipping) and v1.0.6-BETA2 (succeeds with skipping).

@EmteZogaf EmteZogaf self-assigned this Jul 12, 2022
@EmteZogaf EmteZogaf changed the title [WIP] Make Security Scan Job Skippable Make Security Scan Job Skippable Jul 12, 2022
@DiCanio
Copy link

DiCanio commented Jul 13, 2022

Thanks for the feature. Can we make sure to get this into master instead of develop. Since this is only affecting CI we can cut corners here.

@DiCanio
Copy link

DiCanio commented Jul 22, 2022

Related to #12 (PR: #13). Maybe we can close this since the linked PR solves the underlying issue.
Can be discussed after @EmteZogaf comes back from vacation.

@EmteZogaf
Copy link
Collaborator Author

Specific CVE's can be skipped by using the .trivyignore file. Skipping the whole security scan is not needed anymore.

@EmteZogaf EmteZogaf closed this Feb 14, 2023
@michael-82 michael-82 deleted the skip-security-scan branch July 13, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants