refactor: upgrade react and styled-components version #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affects: @medly-components/core, @medly-components/forms, @medly-components/icons, @medly-components/layout, @medly-components/loaders, @medly-components/markdown, @medly-components/utils BREAKING CHANGE: React v18 and styled-components v6 has some breaking changes
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9ce45ab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
affects: @medly-components/core, @medly-components/forms, @medly-components/icons, @medly-components/layout, @medly-components/loaders, @medly-components/markdown, @medly-components/utils
BREAKING CHANGE:
React v18 and styled-components v6 has some breaking changes
PR Checklist
Description
(Replace This Text: Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.)
Type of change
How has this been tested?
(Replace This Text: Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.)
[ ] Test A
[ ] Test B
Fixes #<issue_number>
What is the current behaviour?
(Replace This Text: Please describe the current behaviour you are modifying, or link a relevant issue.)
What is the new behaviour?
(Replace This Text: Please describe the expected new behaviour.)
Does this PR introduce a breaking change?
Note: (Replace This Text: If this PR contains a breaking change please describe the impact and migration path for existing application.)
Additional context
(Replace This Text: Please describe any other related information or add screenshots of the PR.)
Checklist
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules