Skip to content

Commit

Permalink
fix: lint issue and refactor prop name in dashboard component (#37)
Browse files Browse the repository at this point in the history
affects: @medly/create-app
  • Loading branch information
gmukul01 committed Aug 4, 2021
1 parent 0b7c60c commit aca70d4
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 14 deletions.
14 changes: 7 additions & 7 deletions packages/app/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@ Then follow the prompts or you can run command `yarn create @medly/app <project-

### Options

| Flags | Description | Choices | Default |
| ----------------------------------------- | ------------------------------ | --------------------- | ------- |
| `-V, --version` | output the version number | | |
| `-p, --package-manager <package-manager>` | package manager | `npm`, `yarn`, `pnpm` | `yarn` |
| `-s, --state-manager <state-manager>` | state manager | `redux`, `none` | `redux` |
| `-i, --interactive` | show interactive questionnaire | | |
| `-h, --help` | display help for command | | |
| Flags | Description | Choices | Default |
| ----------------------------------------- | ------------------------------ | ------------------------- | ------- |
| `-V, --version` | output the version number | | |
| `-p, --package-manager <package-manager>` | package manager | `npm`, `yarn`, `pnpm` | `yarn` |
| `-s, --state-manager <state-manager>` | state manager | `redux`, `context`,`none` | `redux` |
| `-i, --interactive` | show interactive questionnaire | | |
| `-h, --help` | display help for command | | |

## Features

Expand Down
4 changes: 1 addition & 3 deletions packages/app/template/common/src/pages/Dashboard/types.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
export type StateProps = {
export type DashboardProps = {
isLoading?: boolean;
};

export type Props = StateProps;
6 changes: 2 additions & 4 deletions packages/app/template/stateManagers/redux/src/store/sagas.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import { all } from 'redux-saga/effects';
import { userSaga } from '@store/user';
import { all } from 'redux-saga/effects';

export function* rootSaga(): Generator {
yield all([
userSaga()
]);
yield all([userSaga()]);
}

0 comments on commit aca70d4

Please sign in to comment.