Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve prep scripts in resources + modification to husky hooks #8631

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

shahednasser
Copy link
Member

@shahednasser shahednasser commented Aug 16, 2024

  • Improve the prep scripts of the resources project by only generating the files / slug map for changed files
  • Change husky hooks to run prep in the www monorepo if there are changes in the docs.

Note: since there seems to be a problem with the current husky hook, I added a check before running the current actions that ensures that are changes under pacakges. From my understanding, nobody in the team has husky set up, so this is mainly for my benefit to avoid issues when I'm using it for the docs 😄

Another note: there's an overlap between this PR and PR #8623 . Once both PRs are merged I'll open another with some refactoring.

@shahednasser shahednasser requested a review from a team as a code owner August 16, 2024 14:16
Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 7:20am
api-reference-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 7:20am
docs-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 7:20am
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 7:20am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 7:20am
resources-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 7:20am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 7:20am

Copy link

changeset-bot bot commented Aug 16, 2024

⚠️ No Changeset found

Latest commit: 18bc685

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shahednasser shahednasser requested a review from a team as a code owner August 16, 2024 14:36
@shahednasser shahednasser changed the title docs: improve build scripts in resources docs: improve build scripts in resources + modification to husky hooks Aug 16, 2024
@shahednasser shahednasser changed the title docs: improve build scripts in resources + modification to husky hooks docs: improve prep scripts in resources + modification to husky hooks Aug 16, 2024
Copy link

gitguardian bot commented Aug 18, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
1627328 Triggered Generic Password 106088c integration-tests/http/tests/user/admin/user.spec.ts View secret
1627328 Triggered Generic Password 106088c integration-tests/http/tests/user/admin/user.spec.ts View secret
1627328 Triggered Generic Password 106088c integration-tests/http/tests/user/admin/user.spec.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Sep 19, 2024
@shahednasser
Copy link
Member Author

@olivermrbl can you take a look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants