fix: Exclude deleted price lists and prices from pricing calculations

[panalgin]

Hello,

Description of the bug

A bug was discovered in the pricing calculation logic where deleted price lists and prices were still being considered, potentially leading to incorrect pricing information.

Fix implementation

The fix adds two conditions:

1. A condition to the left join in the calculatePrices method to ensure only non-deleted price lists are considered.
2. A where clause to the base price table select function to exclude deleted prices.

Code changes

1. Price List Join:

.leftJoin("price_list as pl", function () {
  this.on("pl.id", "price.price_list_id").andOn(
    "pl.status",
    knex.raw("?", [PriceListStatus.ACTIVE])
  ).andOn(knex.raw("pl.deleted_at IS NULL"))
})

2. Base Price Table Select:

.where(knex.raw("price.deleted_at IS NULL"))

Impact and importance

These fixes are crucial for accurate pricing calculations, ensuring that only active, non-deleted price lists and prices are considered.

Testing

Unable to write test cases due to module tests not working, but the fixes have been manually verified.

Additional notes

• No new dependencies or API changes.
• Minimal changes addressing specific edge cases.
• Future testing improvements are needed.
• These changes prevent potential issues with pricing calculations that could arise from considering deleted data.

I'm open to any feedback or suggestions for improvement. Thank you for considering this pull request.

Deleting a price list from this screen:

In the database, the record is deleted but because its status still active, and no-check for deleted_at

[changeset-bot]

⚠️ No Changeset found

Latest commit: 704f8c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

@panalgin is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

[carlos-r-l-rodrigues]

LGTM

[riqwan]

good catch! @panalgin

[olivermrbl]

legend @panalgin – thanks for the contribution

[Attachai77]

Could you merge this ?

[fPolic]

This was fixed in the meantime as part of #9265.

[olivermrbl]

@fPolic, can we close this?

[fPolic]

Yes